FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http2: avoid unnecessary buffer resize by lundibundi · Pull Request #34480 · nodejs/node · GitHub

/ node Public

http2: avoid unnecessary buffer resize - #34480

Closed
lundibundi wants to merge 1 commit into
nodejs:masterfrom
lundibundi:fix-old-http2-fix
ConversationCommits (1)ChecksFiles changed
Closed

http2: avoid unnecessary buffer resize#34480
lundibundi wants to merge 1 commit into
nodejs:masterfrom
lundibundi:fix-old-http2-fix

Conversation

lundibundi commented Jul 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Refs: #34315
Refs: #30351

This is what #30351 should've been =).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @nodejs/http2

lundibundi requested a review from Trott July 22, 2020 16:21
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. labels Jul 22, 2020

nodejs-github-bot commented Jul 22, 2020 •
edited by addaleax
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32477/ (:green_heart:)

mcollina approved these changes Jul 22, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 22, 2020
mcollina pushed a commit that referenced this pull request Jul 27, 2020
http2: avoid unnecessary buffer resize
62198d2 
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>

mcollina commented Jul 27, 2020

Copy link
Copy Markdown
Member

Landed in 62198d2

mcollina closed this Jul 27, 2020
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
http2: avoid unnecessary buffer resize
098b193 
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
ruyadorno mentioned this pull request Jul 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Nov 3, 2020
http2: avoid unnecessary buffer resize
8d8d2b4 
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
http2: avoid unnecessary buffer resize
c8a7789 
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
mhdawson mentioned this pull request Jan 18, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes
Trott Awaiting requested review from Trott
+1 more reviewer
devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL