Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@addaleax there are some minor changes to the docs. Please, take a look when you have a spare minute :) |
Sorry, something went wrong.
addaleax
approved these changes
Jul 23, 2020
devsnek
reviewed
Jul 23, 2020
Comment thread
doc/api/console.md
Outdated
Copy link
Copy Markdown
Author
|
@devsnek I made the requested changes. Please, review :) |
Sorry, something went wrong.
BridgeAR
approved these changes
Jul 24, 2020
BridgeAR
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM % comment
Sorry, something went wrong.
Comment thread
doc/api/console.md
Outdated
Add a description and an example of console.assert() call with no arguments. If called like this, the method should output: "Assertion failed". Fixes: #34500 Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message Refs: https://console.spec.whatwg.org/#assert
antsmartian
approved these changes
Jul 24, 2020
antsmartian
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
himself65
approved these changes
Jul 28, 2020
himself65
pushed a commit
that referenced
this pull request
Jul 28, 2020
Add a description and an example of console.assert() call with no arguments. If called like this, the method should output: "Assertion failed". Fixes: #34500 Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message Refs: https://console.spec.whatwg.org/#assert PR-URL: #34501 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
codebytere
pushed a commit
that referenced
this pull request
Aug 5, 2020
Add a description and an example of console.assert() call with no arguments. If called like this, the method should output: "Assertion failed". Fixes: #34500 Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message Refs: https://console.spec.whatwg.org/#assert PR-URL: #34501 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Add a description and an example of console.assert() call with no arguments. If called like this, the method should output: "Assertion failed". Fixes: #34500 Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message Refs: https://console.spec.whatwg.org/#assert PR-URL: #34501 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Add a description and an example of console.assert() call with no arguments. If called like this, the method should output: "Assertion failed". Fixes: #34500 Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message Refs: https://console.spec.whatwg.org/#assert PR-URL: #34501 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a description and an example of console.assert() call with no arguments. If called this way, the method should output: Assertion failed.
Fixes: #34500
Refs: https://nodejs.org/dist/latest-v14.x/docs/api/console.html#console_console_assert_value_message
Refs: https://console.spec.whatwg.org/#assert
Checklist