test: run test-benchmark-napi on arm - #34502
Closed
Trott wants to merge 0 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
marked this pull request as draft
July 24, 2020 04:22
This comment has been minimized.
Trott
marked this pull request as ready for review
July 24, 2020 04:42
richardlau
approved these changes
Jul 24, 2020
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
rickyes
approved these changes
Jul 25, 2020
trivikr
approved these changes
Jul 26, 2020
Trott
added a commit
that referenced
this pull request
Jul 26, 2020
Necessary Makefile changes have happened. This now passes in CI. PR-URL: #34502 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Copy link
Copy Markdown
Member
|
This doesn't land cleanly on v14.x, should it be backported? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
As of this writing, it cherry-picks cleanly to v14.x-staging (which is at d910672). No backport needed anymore? |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Necessary Makefile changes have happened. This now passes in CI. PR-URL: #34502 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary Makefile changes have happened. This now passes in CI.
Checklist