FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: enable http2 team for CODEOWNERS by Trott · Pull Request #34534 · nodejs/node · GitHub

/ node Public

meta: enable http2 team for CODEOWNERS - #34534

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:enable-http2
Aug 7, 2020
ConversationCommits (0)ChecksFiles changed
Merged

meta: enable http2 team for CODEOWNERS#34534
Trott merged 0 commit into
nodejs:masterfrom
Trott:enable-http2

Conversation

Trott commented Jul 28, 2020

Copy link
Copy Markdown
Member

This will require some http2 clean-up before landing. It will also require http2 and net becoming sub-teams of the collaborators team. So I'll mark it blocked for now, but it's ready for reviews.

Checklist

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 28, 2020

mmarchini commented Jul 28, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Do we want to keep adding teams as subteams of collaborators, or should we move forward with something like #34150 / nodejs/github-bot#265? I can get these PRs moving again this week if that's the path we want moving forward.

Trott commented Jul 28, 2020

Copy link
Copy Markdown
Member Author

Do we want to keep adding teams as subteams of collaborators, or should we move forward with something like #34150 / nodejs/github-bot#265? I can get these PRs moving again this week if that's the path we want moving forward.

I'd prefer to avoid the subteams thing, but I don't mind subteams as a temporary measure with what you're working on as the eventual goal.

Trott commented Jul 28, 2020

Copy link
Copy Markdown
Member Author

I just noticed our first "oops, we have someone with Collaborator privileges who is no longer a Collaborator due to the quic subteam" thing. (I've fixed it.)

addaleax approved these changes Jul 28, 2020
View reviewed changes
Comment thread .github/CODEOWNERS Outdated

addaleax Jul 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The only member of the net team who is not in the HTTP/2 team is @indutny, and the team is largely defunct anyway. Not trying to speak for him, but maybe it makes sense to just put @nodejs/http2 everywhere here?

Trott added the blocked PRs that are blocked by other issues or PRs. label Jul 28, 2020
Trott mentioned this pull request Jul 30, 2020
Closed
Trott removed the blocked PRs that are blocked by other issues or PRs. label Aug 7, 2020

Trott commented Aug 7, 2020

Copy link
Copy Markdown
Member Author

Unblocked. Ready to land.

Trott commented Aug 7, 2020

Copy link
Copy Markdown
Member Author

Landed in a11aa9b

Trott closed this Aug 7, 2020
Trott deleted the enable-http2 branch August 7, 2020 02:43
Trott merged commit a11aa9b into nodejs:master Aug 7, 2020
addaleax pushed a commit that referenced this pull request Aug 8, 2020
meta: enable http2 team for CODEOWNERS
650adec 
PR-URL: #34534
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere mentioned this pull request Aug 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Aug 11, 2020
meta: enable http2 team for CODEOWNERS
ffd2c7a 
PR-URL: #34534
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
meta: enable http2 team for CODEOWNERS
05e5aa4 
PR-URL: #34534
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
meta: enable http2 team for CODEOWNERS
ac0b949 
PR-URL: #34534
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere mentioned this pull request Sep 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
jasnell Awaiting requested review from jasnell
MylesBorins Awaiting requested review from MylesBorins

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL