doc: revise N-API versions matrix text - #34566
Closed
Trott wants to merge 0 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
devsnek
approved these changes
Jul 30, 2020
richardlau
reviewed
Jul 30, 2020
Comment thread
doc/api/n-api.md
Outdated
richardlau
reviewed
Jul 30, 2020
Comment thread
doc/api/n-api.md
Outdated
mhdawson
approved these changes
Jul 30, 2020
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
richardlau
approved these changes
Jul 30, 2020
jasnell
approved these changes
Jul 30, 2020
Trott
added a commit
that referenced
this pull request
Aug 2, 2020
Revise text for clarity, brevity, and conformance with our style guide. PR-URL: #34566 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Aug 5, 2020
Revise text for clarity, brevity, and conformance with our style guide. PR-URL: #34566 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revise text for clarity, brevity, and conformance with our style guide.
Checklist