FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update fs.watch() availability for IBM i · Pull Request #34611 · nodejs/node · GitHub

/ node Public

doc: update fs.watch() availability for IBM i - #34611

Closed
ghost wants to merge 1 commit into
masterfrom
unknown repository
ConversationCommits (1)ChecksFiles changed
Closed

doc: update fs.watch() availability for IBM i#34611
ghost wants to merge 1 commit into
masterfrom
unknown repository

Conversation

ghost commented Aug 3, 2020

Copy link
Copy Markdown

Add a line that IBM i does not support fs.watch().

Fixes: #34607
Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability

Checklist

nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Aug 3, 2020
ghost commented Aug 3, 2020
View reviewed changes
Comment thread doc/api/fs.md Outdated

ghost Aug 3, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I didn't add any line suggesting to use fs.watchFile() as this option is mentioned later.

ghost commented Aug 3, 2020

Copy link
Copy Markdown
Author

@richardlau take a look when you have a spare minute

richardlau reviewed Aug 3, 2020
View reviewed changes

richardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you undo the unrelated table formatting changes?

richardlau commented Aug 3, 2020

Copy link
Copy Markdown
Member

cc @nodejs/platform-ibmi

ghost commented Aug 3, 2020

Copy link
Copy Markdown
Author

@richardlau Sure

Probably some formatting is done by my IDE. I'll fix this

ghost commented Aug 3, 2020
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've deleted the unnecessary table formatting. That was done automatically by my IDE.

richardlau added ibm i Issues and PRs related to the IBM i platform. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Aug 3, 2020

ThePrez commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

LGTM. Thanks, @iandrc!!

ghost commented Aug 3, 2020

Copy link
Copy Markdown
Author

@ThePrez np :)

jasnell pushed a commit that referenced this pull request Aug 7, 2020
doc: update fs.watch() availability for IBM i
0dff5bc 
Add a line that IBM i does not support `fs.watch()`.

Fixes: #34607
Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability

PR-URL: #34611
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Aug 7, 2020

Copy link
Copy Markdown
Member

Landed in 0dff5bc

jasnell closed this Aug 7, 2020
addaleax pushed a commit that referenced this pull request Aug 8, 2020
doc: update fs.watch() availability for IBM i
dd6bf20 
Add a line that IBM i does not support `fs.watch()`.

Fixes: #34607
Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability

PR-URL: #34611
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Aug 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Aug 11, 2020
doc: update fs.watch() availability for IBM i
767a5cb 
Add a line that IBM i does not support `fs.watch()`.

Fixes: #34607
Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability

PR-URL: #34611
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
doc: update fs.watch() availability for IBM i
fac6107 
Add a line that IBM i does not support `fs.watch()`.

Fixes: #34607
Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability

PR-URL: #34611
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
doc: update fs.watch() availability for IBM i
3dda55a 
Add a line that IBM i does not support `fs.watch()`.

Fixes: #34607
Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability

PR-URL: #34611
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. ibm i Issues and PRs related to the IBM i platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc Document that IBM i does not support API fs.watch()

4 participants

Back | FazBrowse Home | New Git URL