FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc,napi: N-API environment life cycle APIs are stable by jschlight · Pull Request #34641 · nodejs/node · GitHub

/ node Public

doc,napi: N-API environment life cycle APIs are stable - #34641

Closed
jschlight wants to merge 1 commit into
nodejs:masterfrom
jschlight:napi-doc
Closed

doc,napi: N-API environment life cycle APIs are stable#34641
jschlight wants to merge 1 commit into
nodejs:masterfrom
jschlight:napi-doc

Conversation

Copy link
Copy Markdown
Contributor

@gabrielschulhof indicates that the N-API Environment Life Cycle APIs are now stable.

Checklist

nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Aug 6, 2020

Trott commented Aug 8, 2020

Copy link
Copy Markdown
Member

@nodejs/n-api

rickyes added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 10, 2020

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell pushed a commit that referenced this pull request Aug 11, 2020
PR-URL: #34641
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell commented Aug 11, 2020

Copy link
Copy Markdown
Member

Landed in bbdb013

jasnell closed this Aug 11, 2020
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
PR-URL: #34641
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
danielleadams mentioned this pull request Aug 20, 2020
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
PR-URL: #34641
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jschlight deleted the napi-doc branch August 21, 2020 22:37
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34641
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34641
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
codebytere mentioned this pull request Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL