FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: do not run auto-start-ci on forks by evanlucas · Pull Request #34650 · nodejs/node · GitHub

/ node Public

build: do not run auto-start-ci on forks - #34650

Closed
evanlucas wants to merge 1 commit into
nodejs:masterfrom
evanlucas:workflow-forks-auto-start-ci
ConversationCommits (1)ChecksFiles changed
Closed

build: do not run auto-start-ci on forks#34650
evanlucas wants to merge 1 commit into
nodejs:masterfrom
evanlucas:workflow-forks-auto-start-ci

Conversation

evanlucas commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

Previously, the auto-start-ci action would run on forks.
Without the secrets, the action would fail over and over again.
This caused a lot of email spam. Now, we only run this action
when the repository is nodejs/node.

/cc @mmarchini I think this should work, although I'm not sure how to test...

Checklist

build: do not run auto-start-ci on forks
22b078f 
Previously, the auto-start-ci action would run on forks.
Without the secrets, the action would fail over and over again.
This caused a lot of email spam. Now, we only run this action
when the repository is nodejs/node.
evanlucas requested a review from mmarchini August 6, 2020 16:50
nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 6, 2020

mmarchini commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

Can we instead check if the secrets are present, and if not skip the run? I'd like this to still work on forks since sometimes we test this kind of thing on nodejs/node-auto-tools.

evanlucas commented Aug 6, 2020

Copy link
Copy Markdown
Contributor Author

@mmarchini that's a good point. Lemme see what I can do

mmarchini reviewed Aug 6, 2020
View reviewed changes
Comment thread .github/workflows/auto-start-ci.yml

jobs:
startCI:
if: github.repository == 'nodejs/node'

mmarchini Aug 6, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
if: github.repository == 'nodejs/node'
if: secrets.JENKINS_USER && secrets.JENKINS_TOKEN

Also not sure if it works. Feel free to try on nodejs/node-auto-test first (I can re-enable Actions there, just give me a ping).

mmarchini Aug 6, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It might need to be

Suggested change
if: github.repository == 'nodejs/node'
if: ${{ secrets.JENKINS_USER && secrets.JENKINS_TOKEN }}

https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#about-contexts-and-expressions

evanlucas Aug 6, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

https://github.community/t/jobs-job-id-if-does-not-work-with-env-secrets/16928/5 It doesn't sound like it does work...

mmarchini commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

@evanlucas I re-enabled Actions on https://github.com/nodejs/node-auto-test. Let's test there first, since the Action is working here it's better if we're sure the changes will work.

evanlucas commented Aug 6, 2020

Copy link
Copy Markdown
Contributor Author

Sounds good. I'll open a PR over there. I think I've found a way to do it

mmarchini commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

FWIW you should be able to test on a personal fork as well, just push the changes to master there :)

mmarchini approved these changes Aug 6, 2020
View reviewed changes

mmarchini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's move forward with this approach for now, we can't use secrets on conditionals and even with workarounds to check if conditionals exist, cancelling the run will also trigger notifications.

mmarchini commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

fast track?

richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 7, 2020

mmarchini commented Aug 7, 2020

Copy link
Copy Markdown
Contributor

Landed in ac5773b

mmarchini closed this Aug 7, 2020
mmarchini pushed a commit that referenced this pull request Aug 7, 2020
build: do not run auto-start-ci on forks
ac5773b 
Previously, the auto-start-ci action would run on forks.
Without the secrets, the action would fail over and over again.
This caused a lot of email spam. Now, we only run this action
when the repository is nodejs/node.

PR-URL: #34650
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Aug 8, 2020
build: do not run auto-start-ci on forks
6a129d0 
Previously, the auto-start-ci action would run on forks.
Without the secrets, the action would fail over and over again.
This caused a lot of email spam. Now, we only run this action
when the repository is nodejs/node.

PR-URL: #34650
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere mentioned this pull request Aug 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Aug 11, 2020
build: do not run auto-start-ci on forks
f0b364f 
Previously, the auto-start-ci action would run on forks.
Without the secrets, the action would fail over and over again.
This caused a lot of email spam. Now, we only run this action
when the repository is nodejs/node.

PR-URL: #34650
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
build: do not run auto-start-ci on forks
587b661 
Previously, the auto-start-ci action would run on forks.
Without the secrets, the action would fail over and over again.
This caused a lot of email spam. Now, we only run this action
when the repository is nodejs/node.

PR-URL: #34650
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
build: do not run auto-start-ci on forks
f6ad59b 
Previously, the auto-start-ci action would run on forks.
Without the secrets, the action would fail over and over again.
This caused a lot of email spam. Now, we only run this action
when the repository is nodejs/node.

PR-URL: #34650
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
richardlau richardlau approved these changes
+1 more reviewer
mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL