FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: tidy some addons.md text by Trott · Pull Request #34654 · nodejs/node · GitHub

/ node Public

doc: tidy some addons.md text - #34654

Closed
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:eg
Closed

doc: tidy some addons.md text#34654
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:eg

Conversation

Trott commented Aug 6, 2020

Copy link
Copy Markdown
Member
Checklist

nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Aug 6, 2020
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 7, 2020
jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 7, 2020

jasnell commented Aug 7, 2020

Copy link
Copy Markdown
Member

Fast track? There's really no reason to make this wait longer. Please 👍🏻

Trott commented Aug 8, 2020

Copy link
Copy Markdown
Member Author

Landed in bdfc598

Trott added a commit that referenced this pull request Aug 8, 2020
PR-URL: #34654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott closed this Aug 8, 2020
Trott deleted the eg branch August 8, 2020 23:46
codebytere pushed a commit that referenced this pull request Aug 10, 2020
PR-URL: #34654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere mentioned this pull request Aug 10, 2020
codebytere pushed a commit that referenced this pull request Aug 11, 2020
PR-URL: #34654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere mentioned this pull request Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL