FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

n-api: fix use-after-free with napi_remove_async_cleanup_hook by addaleax · Pull Request #34662 · nodejs/node · GitHub

/ node Public

n-api: fix use-after-free with napi_remove_async_cleanup_hook - #34662

Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:fix-napi-async-cleanup-uaf
ConversationCommits (3)ChecksFiles changed
Closed

n-api: fix use-after-free with napi_remove_async_cleanup_hook#34662
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:fix-napi-async-cleanup-uaf

Conversation

addaleax commented Aug 7, 2020

Copy link
Copy Markdown
Member

Fixes: #34657
Refs: #34572

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Aug 7, 2020
addaleax added 3 commits August 7, 2020 16:25
src: fix size underflow in CallbackQueue
7ff8795 
Only decrease the size when actually removing items.
src: spin shutdown loop while immediates are pending
60941d6 
This allows using `SetImmediate()` and friends at any point
during cleanup.
n-api: fix use-after-free with napi_remove_async_cleanup_hook
b94ceaf 
Fixes: nodejs#34657
Refs: nodejs#34572
addaleax force-pushed the fix-napi-async-cleanup-uaf branch from 5748020 to b94ceaf Compare August 7, 2020 14:40
gabrielschulhof added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 7, 2020

gabrielschulhof commented Aug 7, 2020

Copy link
Copy Markdown
Contributor

Shall we fast-track, given that this is breaking the CI?

nodejs-github-bot commented Aug 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32666/

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 7, 2020

nodejs-github-bot commented Aug 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32668/

nodejs-github-bot commented Aug 7, 2020 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32672/ 💚

jasnell pushed a commit that referenced this pull request Aug 7, 2020
src: fix size underflow in CallbackQueue
9511261 
Only decrease the size when actually removing items.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Aug 7, 2020
src: spin shutdown loop while immediates are pending
09c5942 
This allows using `SetImmediate()` and friends at any point
during cleanup.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Aug 7, 2020
n-api: fix use-after-free with napi_remove_async_cleanup_hook
262d0d0 
Fixes: #34657
Refs: #34572

PR-URL: #34662
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Aug 7, 2020

Copy link
Copy Markdown
Member

Landed in 9511261, 09c5942, and 262d0d0

jasnell closed this Aug 7, 2020
This was referenced Aug 8, 2020
Open
Open
addaleax added a commit that referenced this pull request Aug 8, 2020
src: fix size underflow in CallbackQueue
39ca48c 
Only decrease the size when actually removing items.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Aug 8, 2020
src: spin shutdown loop while immediates are pending
2761f34 
This allows using `SetImmediate()` and friends at any point
during cleanup.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Aug 8, 2020
n-api: fix use-after-free with napi_remove_async_cleanup_hook
fbd411d 
Fixes: #34657
Refs: #34572

PR-URL: #34662
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Aug 9, 2020
Open
Open
Open
Open
codebytere mentioned this pull request Aug 10, 2020
Merged
github-actions Bot mentioned this pull request Aug 11, 2020
Open
11 tasks
github-actions Bot mentioned this pull request Aug 11, 2020
Open
11 tasks
codebytere pushed a commit that referenced this pull request Aug 11, 2020
src: fix size underflow in CallbackQueue
3132878 
Only decrease the size when actually removing items.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Aug 11, 2020
src: spin shutdown loop while immediates are pending
4369c2a 
This allows using `SetImmediate()` and friends at any point
during cleanup.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Aug 11, 2020
n-api: fix use-after-free with napi_remove_async_cleanup_hook
4ed89a3 
Fixes: #34657
Refs: #34572

PR-URL: #34662
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Aug 12, 2020
Open
Open
Open
Open
addaleax added a commit that referenced this pull request Sep 22, 2020
src: fix size underflow in CallbackQueue
264f003 
Only decrease the size when actually removing items.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Sep 22, 2020
src: spin shutdown loop while immediates are pending
01107cc 
This allows using `SetImmediate()` and friends at any point
during cleanup.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Sep 22, 2020
src: fix size underflow in CallbackQueue
dabd04d 
Only decrease the size when actually removing items.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Sep 22, 2020
src: spin shutdown loop while immediates are pending
1549048 
This allows using `SetImmediate()` and friends at any point
during cleanup.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Sep 22, 2020
n-api: fix use-after-free with napi_remove_async_cleanup_hook
c440748 
Fixes: #34657
Refs: #34572

PR-URL: #34662
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
gabrielschulhof gabrielschulhof approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ASAN tests failing

4 participants

Back | FazBrowse Home | New Git URL