errors: improve ERR_INVALID_OPT_VALUE message - #34671
Closed
lundibundi wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
* use util.inspect for value presentation * allow to optionally specify error reason
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Aug 7, 2020
3 tasks
Trott
reviewed
Aug 9, 2020
Comment thread
lib/internal/errors.js
Outdated
Trott
reviewed
Aug 9, 2020
Comment thread
test/parallel/test-crypto-keygen.js
Outdated
Trott
approved these changes
Aug 9, 2020
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Left two optional nits, but looks good to me with or without them.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mmarchini
approved these changes
Aug 15, 2020
mmarchini
pushed a commit
that referenced
this pull request
Aug 15, 2020
* use util.inspect for value presentation * allow to optionally specify error reason PR-URL: #34671 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
* use util.inspect for value presentation * allow to optionally specify error reason PR-URL: #34671 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
* use util.inspect for value presentation * allow to optionally specify error reason PR-URL: #34671 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
* use util.inspect for value presentation * allow to optionally specify error reason PR-URL: #34671 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
* use util.inspect for value presentation * allow to optionally specify error reason PR-URL: #34671 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
I also thought of changing the message from always having the quotes (i.e. "42" -> 42) around value to make it easier to distinguish between different value types (i.e. string vs number), wdyt?