test: remove test-child-process-fork-args flaky designation - #34684
Closed
Trott wants to merge 0 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Aug 10, 2020
Copy link
Copy Markdown
Member
Author
|
@nodejs/testing This could use another review. |
Sorry, something went wrong.
rexagod
approved these changes
Aug 10, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
added a commit
that referenced
this pull request
Aug 11, 2020
test-child-process-fork-args does not appear in results from `ncu-ci walk commit` and no one has reported it failing for several months. A stress test also passed. Closes: #32863 PR-URL: #34684 Fixes: #32863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
test-child-process-fork-args does not appear in results from `ncu-ci walk commit` and no one has reported it failing for several months. A stress test also passed. Closes: #32863 PR-URL: #34684 Fixes: #32863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
test-child-process-fork-args does not appear in results from `ncu-ci walk commit` and no one has reported it failing for several months. A stress test also passed. Closes: #32863 PR-URL: #34684 Fixes: #32863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
test-child-process-fork-args does not appear in results from `ncu-ci walk commit` and no one has reported it failing for several months. A stress test also passed. Closes: #32863 PR-URL: #34684 Fixes: #32863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
test-child-process-fork-args does not appear in results from `ncu-ci walk commit` and no one has reported it failing for several months. A stress test also passed. Closes: #32863 PR-URL: #34684 Fixes: #32863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-child-process-fork-args does not appear in results from ncu-ci walk commit and no one has reported it failing for several months.
A stress test also passed.
Closes: #32863
Checklist