FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use process.env.PYTHON to spawn python by addaleax · Pull Request #34700 · nodejs/node · GitHub

/ node Public

test: use process.env.PYTHON to spawn python - #34700

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:fix-34699
ConversationCommits (1)ChecksFiles changed
Closed

test: use process.env.PYTHON to spawn python#34700
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:fix-34699

Conversation

addaleax commented Aug 9, 2020

Copy link
Copy Markdown
Member

Fixes: #34699

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

test: use process.env.PYTHON to spawn python
3b12b5a 
Co-authored-by: Jérémy Lal <kapouer@melix.org>
Fixes: nodejs#34699
nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 9, 2020
addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2020

nodejs-github-bot commented Aug 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32697/

This was referenced Aug 10, 2020
Open
Open
gengjiawen approved these changes Aug 10, 2020
View reviewed changes

gengjiawen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Any thought export this in common ?

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 10, 2020

nodejs-github-bot commented Aug 10, 2020 •
edited by rickyes
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32702/ ✅

addaleax commented Aug 10, 2020

Copy link
Copy Markdown
Member Author

Any thought export this in common ?

I don’t have a strong opinion on that.

This was referenced Aug 11, 2020
Open
Open
Open
Open
Open
Open
This was referenced Aug 14, 2020
Open
Open
rickyes pushed a commit that referenced this pull request Aug 14, 2020
test: use process.env.PYTHON to spawn python
888eb5a 
Co-authored-by: Jérémy Lal <kapouer@melix.org>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

rickyes commented Aug 14, 2020

Copy link
Copy Markdown
Contributor

Landed in 888eb5a

rickyes closed this Aug 14, 2020
github-actions Bot mentioned this pull request Aug 15, 2020
Open
6 tasks
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
test: use process.env.PYTHON to spawn python
e0e8544 
Co-authored-by: Jérémy Lal <kapouer@melix.org>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
test: use process.env.PYTHON to spawn python
a78c638 
Co-authored-by: Jérémy Lal <kapouer@melix.org>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax added a commit that referenced this pull request Sep 22, 2020
test: use process.env.PYTHON to spawn python
9565d59 
Co-authored-by: Jérémy Lal <kapouer@melix.org>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax added a commit that referenced this pull request Sep 22, 2020
test: use process.env.PYTHON to spawn python
9cde4eb 
Co-authored-by: Jérémy Lal <kapouer@melix.org>
Fixes: #34699

PR-URL: #34700
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
gengjiawen gengjiawen approved these changes
richardlau richardlau approved these changes
+2 more reviewers
rickyes rickyes approved these changes
Nelias Nelias approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some tests call python instead of env.PYTHON

8 participants

Back | FazBrowse Home | New Git URL