test: fix test_worker_terminate_finalization - #34726
Closed
addaleax wants to merge 1 commit into
Hidden character warning
The head ref may contain hidden characters: "bl\u00f6rp"
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in nodejs#34625.
Copy link
Copy Markdown
Member
Author
|
Please 👍 to fast-track |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
4 tasks
richardlau
approved these changes
Aug 11, 2020
Copy link
Copy Markdown
Member
|
Ok, now I'm really curious why this wasn't failing consistently in other CI runs! So happy you found this! |
Sorry, something went wrong.
jasnell
approved these changes
Aug 11, 2020
rickyes
approved these changes
Aug 11, 2020
Copy link
Copy Markdown
Member
Author
I think your PR changes GC timing in some way – previously, the finalizer was run during shutdown, where no JS calls are allowed anyway (i.e. the NAPI_PREAMBLE in napi_throw_error() prevents the function from doing anything but failing). With your PR, the finalizer is scheduled to run from actual GC on some platforms, so it can cause uncaught exceptions in JS. |
Sorry, something went wrong.
addaleax
added a commit
that referenced
this pull request
Aug 11, 2020
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in #34625. PR-URL: #34726 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Copy link
Copy Markdown
Member
Author
|
Landed in 9f47e5a, thanks for the quick reviews! |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in #34625. PR-URL: #34726 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in #34625. PR-URL: #34726 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in #34625. PR-URL: #34726 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in #34625. PR-URL: #34726 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was missing an initialization of the global ref variable
because there was also an unused local one, leading to failures
like the one seen in #34625.
Checklist