FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: skip node-api/test_worker_terminate_finalization by addaleax · Pull Request #34732 · nodejs/node · GitHub

/ node Public

test: skip node-api/test_worker_terminate_finalization - #34732

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:no-test_worker_terminate_finalization
ConversationCommits (1)ChecksFiles changed
Closed

test: skip node-api/test_worker_terminate_finalization#34732
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:no-test_worker_terminate_finalization

Conversation

addaleax commented Aug 11, 2020

Copy link
Copy Markdown
Member

The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

test: skip node-api/test_worker_terminate_finalization
1078495 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: nodejs#34731
nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 11, 2020

addaleax commented Aug 11, 2020

Copy link
Copy Markdown
Member Author

👍 to fast-track to unbreak test-asan?

addaleax added fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 11, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2020

nodejs-github-bot commented Aug 11, 2020 •
edited by addaleax
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32735/ (:green_heart:)

mmarchini pushed a commit that referenced this pull request Aug 12, 2020
test: skip node-api/test_worker_terminate_finalization
cf5d7c0 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

PR-URL: #34732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>

mmarchini commented Aug 12, 2020

Copy link
Copy Markdown
Contributor

Landed in cf5d7c0

mmarchini closed this Aug 12, 2020
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
test: skip node-api/test_worker_terminate_finalization
e5a3991 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

PR-URL: #34732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
test: skip node-api/test_worker_terminate_finalization
0472d16 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

PR-URL: #34732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
addaleax added a commit that referenced this pull request Sep 22, 2020
test: skip node-api/test_worker_terminate_finalization
3b70c10 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

PR-URL: #34732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
addaleax added a commit that referenced this pull request Sep 22, 2020
test: skip node-api/test_worker_terminate_finalization
335b61a 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

PR-URL: #34732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
codebytere mentioned this pull request Sep 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL