FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: allow ENFILE in test-worker-init-failure by Trott · Pull Request #34769 · nodejs/node · GitHub

/ node Public

test: allow ENFILE in test-worker-init-failure - #34769

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:enfile
Aug 16, 2020
ConversationCommits (0)ChecksFiles changed
Merged

test: allow ENFILE in test-worker-init-failure#34769
Trott merged 0 commit into
nodejs:masterfrom
Trott:enfile

Conversation

Trott commented Aug 14, 2020

Copy link
Copy Markdown
Member

Refs: #34727 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 14, 2020
Trott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Aug 14, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2020

nodejs-github-bot commented Aug 14, 2020 •
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32776/

Trott commented Aug 14, 2020

Copy link
Copy Markdown
Member Author

I've added ENOENT as well. PTAL.

nodejs-github-bot commented Aug 14, 2020 •
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32794/ ✅

github-actions Bot mentioned this pull request Aug 15, 2020
Open
6 tasks
bnoordhuis approved these changes Aug 15, 2020
View reviewed changes
Comment thread test/parallel/test-worker-init-failure.js Outdated
github-actions Bot mentioned this pull request Aug 16, 2020
Open
6 tasks

Trott commented Aug 16, 2020

Copy link
Copy Markdown
Member Author

Landed in 375b859...0e1fd8d

Trott added a commit to Trott/io.js that referenced this pull request Aug 16, 2020
test: allow ENFILE in test-worker-init-failure
97d9b9c 
Refs: nodejs#34727 (comment)

PR-URL: nodejs#34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Trott closed this Aug 16, 2020
Trott merged commit 0e1fd8d into nodejs:master Aug 16, 2020
Trott deleted the enfile branch August 16, 2020 14:40
github-actions Bot mentioned this pull request Aug 17, 2020
Open
6 tasks
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
test: allow ENFILE in test-worker-init-failure
fcb5d95 
Refs: #34727 (comment)

PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
test: allow ENOENT in test-worker-init-failure
b202ba8 
PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
github-actions Bot mentioned this pull request Aug 18, 2020
Open
5 tasks
This was referenced Aug 19, 2020
Open
Open
danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
test: allow ENFILE in test-worker-init-failure
88919e5 
Refs: #34727 (comment)

PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
test: allow ENOENT in test-worker-init-failure
1c324d5 
PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
github-actions Bot mentioned this pull request Aug 21, 2020
Open
9 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
test: allow ENFILE in test-worker-init-failure
ac620b0 
Refs: #34727 (comment)

PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
test: allow ENOENT in test-worker-init-failure
7c09012 
PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
test: allow ENFILE in test-worker-init-failure
238d01f 
Refs: #34727 (comment)

PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
test: allow ENOENT in test-worker-init-failure
5352cde 
PR-URL: #34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
gireeshpunathil gireeshpunathil approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
richardlau richardlau approved these changes
+2 more reviewers
lundibundi lundibundi approved these changes
rickyes rickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL