Update esm.md - #34786
Closed
frank-dspeed wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fixed Reference as the file name is main.mjs and not main.js
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
targos
approved these changes
Aug 15, 2020
Comment thread
doc/api/esm.md
Outdated
DerekNonGeneric
approved these changes
Aug 15, 2020
DerekNonGeneric
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for fixing this. I saw this problem a few days ago, but never got around to fixing it myself. Cheers!
Sorry, something went wrong.
Co-authored-by: Derek Lewis <DerekNonGeneric@inf.is>
GeoffreyBooth
approved these changes
Aug 16, 2020
MrHeer
approved these changes
Aug 16, 2020
addaleax
approved these changes
Aug 18, 2020
jasnell
approved these changes
Aug 18, 2020
Copy link
Copy Markdown
Contributor
|
Just as a note for a future TODO. We should make all of these like the following: node --experimental-loader=./https-loader.mjs ./main.mjs |
Sorry, something went wrong.
Trott
approved these changes
Aug 19, 2020
Trott
pushed a commit
that referenced
this pull request
Aug 19, 2020
PR-URL: #34786 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in 6e97a73. Thanks for the contribution! 🎉 |
Sorry, something went wrong.
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
PR-URL: #34786 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
PR-URL: #34786 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34786 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34786 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Reference as the file name is main.mjs and not main.js
Checklist