These tests should fail if the env is set to dumb. If they don't, then that's something to fix.

Yeah, my hope is that the tests fail here (which is why I have this in draft mode) and then pass if we spawn a subprocess with a different TERM setting and possibly a few other modifications to the test.

@nodejs/repl

Yeah, my hope is that the tests fail here (which is why I have this in draft mode) and then pass if we spawn a subprocess with a different TERM setting and possibly a few other modifications to the test.

Turns out it didn't need to do any spawning. Since the output never goes to the actual terminal anyway, we can set the TERM environment variable to whatever we want and run the test normally.

CI: https://ci.nodejs.org/job/node-test-pull-request/32861/

CI: https://ci.nodejs.org/job/node-test-pull-request/32864/

- Loading data for nodejs/node/pull/34798
✔  Done loading data for nodejs/node/pull/34798
----------------------------------- PR info ------------------------------------
Title      test: run REPL preview test regardless of terminal type (#34798)
Author     Rich Trott  (@Trott)
Branch     Trott:terminal-type -> nodejs:master
Labels     author ready, test
Commits    2
 - test: run REPL preview test regardless of terminal type
 - fixup! test: run REPL preview test regardless of terminal type
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/34798
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Mary Marchini 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/34798
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Mary Marchini 
--------------------------------------------------------------------------------
   ℹ  Last Full PR CI on 2020-08-20T02:19:41Z: https://ci.nodejs.org/job/node-test-pull-request/32864/
- Querying data of job/node-test-pull-request/32864/
✔  Build data downloaded
   ℹ  This PR was created on Sun, 16 Aug 2020 17:37:52 GMT
   ✔  Approvals: 3
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/34798#pullrequestreview-470512232
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/34798#pullrequestreview-470592782
   ✔  - Mary Marchini (@mmarchini) (TSC): https://github.com/nodejs/node/pull/34798#pullrequestreview-471078394
--------------------------------------------------------------------------------
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch              master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 34798
✔  Downloaded patch to /home/runner/work/node/node/.ncu/34798/patch
--------------------------------------------------------------------------------
Applying: test: run REPL preview test regardless of terminal type
Applying: fixup! test: run REPL preview test regardless of terminal type
   ✔  Patches applied
There are 2 commits in the PR
Please run the following commands to complete landing
$ git rebase origin/master -i -x "git node land --amend" --autosquash

$ git node land --continue

Commit queue failed as at the moment it can only handle single commit pull requests (I forgot this too in another PR). This could be landed manually, but it could also be a good candidate to test out nodejs/node-core-utils#473. cc @mmarchini

Landed in 6130cdd