FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: move addaleax to TSC emeritus by addaleax · Pull Request #34809 · nodejs/node · GitHub

/ node Public

doc: move addaleax to TSC emeritus - #34809

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:addaleax-tsc-emeriti
ConversationCommits (1)ChecksFiles changed
Closed

doc: move addaleax to TSC emeritus#34809
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:addaleax-tsc-emeriti

Conversation

addaleax commented Aug 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This will be my last week of working on Node.js full-time, so after this, my involvement will be reduced a lot, so being on the TSC doesn’t really make sense anymore for me.

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 17, 2020

addaleax commented Aug 17, 2020

Copy link
Copy Markdown
Member Author

fyi @nodejs/tsc

mcollina approved these changes Aug 17, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

bnb commented Aug 17, 2020

Copy link
Copy Markdown
Contributor

thank you for the years of time, energy, and care you've put into the TSC and the project @addaleax 💚

jasnell commented Aug 17, 2020

Copy link
Copy Markdown
Member

Simply out of "NOOOOOOO! I don't want to admit it's true!!!!" I'm not going to hit "Approve" on this.

Fishrock123 commented Aug 17, 2020

Copy link
Copy Markdown
Contributor

@addaleax Thanks for everything!

richardlau mentioned this pull request Aug 17, 2020
Merged
tniessen approved these changes Aug 17, 2020
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for... so much.

rickyes approved these changes Aug 18, 2020
View reviewed changes

rickyes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for everything you've done over the years! ❤️

XadillaX commented Aug 18, 2020

Copy link
Copy Markdown
Contributor

I wish you a happy voyage. 😳

gengjiawen commented Aug 18, 2020

Copy link
Copy Markdown
Member

Very happy working with you and gonna miss you for a long time :(

Trott approved these changes Aug 18, 2020
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the four years of service on CTC/TSC. Looking forward to seeing where new adventures take you.

mhdawson approved these changes Aug 18, 2020
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

addaleax added a commit that referenced this pull request Aug 19, 2020
doc: move addaleax to TSC emeritus
5acc69c 
PR-URL: #34809
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

addaleax commented Aug 19, 2020

Copy link
Copy Markdown
Member Author

Landed in 5acc69c :)

addaleax closed this Aug 19, 2020
addaleax deleted the addaleax-tsc-emeriti branch August 19, 2020 23:19
addaleax added a commit to nodejs/email that referenced this pull request Aug 19, 2020
Remove addaleax from all email aliases
6d31e24 
Refs: nodejs/node#34809
addaleax mentioned this pull request Aug 19, 2020
Merged
rvagg pushed a commit to nodejs/email that referenced this pull request Aug 19, 2020
Remove addaleax from all email aliases (#162)
6cdd348 
Refs: nodejs/node#34809
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
doc: move addaleax to TSC emeritus
916ab9e 
PR-URL: #34809
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
doc: move addaleax to TSC emeritus
3133b75 
PR-URL: #34809
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax added a commit that referenced this pull request Sep 22, 2020
doc: move addaleax to TSC emeritus
9e4b866 
PR-URL: #34809
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax added a commit that referenced this pull request Sep 22, 2020
doc: move addaleax to TSC emeritus
9d52480 
PR-URL: #34809
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
uneoka0114 pushed a commit to uneoka0114/NodeJS-Email that referenced this pull request Jul 16, 2024
Remove addaleax from all email aliases (#162)
592cb51 
Refs: nodejs/node#34809
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
Trott Trott approved these changes
codebytere codebytere approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
gengjiawen gengjiawen approved these changes
richardlau richardlau approved these changes
gireeshpunathil gireeshpunathil approved these changes
trivikr trivikr approved these changes
+6 more reviewers
fhinkel fhinkel approved these changes
targos targos approved these changes
XadillaX XadillaX approved these changes
hiroppy hiroppy approved these changes
mhdawson mhdawson approved these changes
rickyes rickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL