build: run link checker in linter workflow - #34810
Closed
richardlau wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment has been minimized.
mmarchini
approved these changes
Aug 17, 2020
This comment has been minimized.
Signed-off-by: Richard Lau <riclau@uk.ibm.com>
jasnell
approved these changes
Aug 17, 2020
Change format of logged messages when run on GitHub Actions (i.e. when the `GITHUB_ACTIONS` environment variable is true) so that broken links are highlighted inline in pull requests. Signed-off-by: Richard Lau <riclau@uk.ibm.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gengjiawen
approved these changes
Aug 18, 2020
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/34810 ✔ Done loading data for nodejs/node/pull/34810 ----------------------------------- PR info ------------------------------------ Title build: run link checker in linter workflow (#34810) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch richardlau:checklinks -> nodejs:master Labels author ready, doc, meta, tools Commits 2 - build: run link checker in linter workflow - doc,tools: annotate broken links in actions workflow Committers 1 - Richard Lau PR-URL: https://github.com/nodejs/node/pull/34810 Refs: https://github.com/nodejs/node/issues/34787 Reviewed-By: Mary Marchini Reviewed-By: James M Snell Reviewed-By: Jiawen Geng ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/34810 Refs: https://github.com/nodejs/node/issues/34787 Reviewed-By: Mary Marchini Reviewed-By: James M Snell Reviewed-By: Jiawen Geng -------------------------------------------------------------------------------- ℹ Last Full PR CI on 2020-08-17T20:12:30Z: https://ci.nodejs.org/job/node-test-pull-request/32814/ - Querying data of job/node-test-pull-request/32814/ ✔ Build data downloaded ℹ This PR was created on Mon, 17 Aug 2020 17:05:19 GMT ✔ Approvals: 3 ✔ - Mary Marchini (@mmarchini) (TSC): https://github.com/nodejs/node/pull/34810#pullrequestreview-468672962 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/34810#pullrequestreview-468746762 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/34810#pullrequestreview-468943560 -------------------------------------------------------------------------------- ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 34810 ✔ Downloaded patch to /home/runner/work/node/node/.ncu/34810/patch -------------------------------------------------------------------------------- Applying: build: run link checker in linter workflow Applying: doc,tools: annotate broken links in actions workflow ✔ Patches applied There are 2 commits in the PR Please run the following commands to complete landing |
Sorry, something went wrong.
Trott
approved these changes
Aug 19, 2020
Trott
pushed a commit
that referenced
this pull request
Aug 19, 2020
Change format of logged messages when run on GitHub Actions (i.e. when the `GITHUB_ACTIONS` environment variable is true) so that broken links are highlighted inline in pull requests. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #34810 Refs: #34787 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Copy link
Copy Markdown
Member
|
(Oh, I see the commit queue tag was added less than an hour ago. Hope I didn't jump the gun by landing it. Sorry if I've made it harder to debug the problem it was having!) |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Change format of logged messages when run on GitHub Actions (i.e. when the `GITHUB_ACTIONS` environment variable is true) so that broken links are highlighted inline in pull requests. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #34810 Refs: #34787 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced May 27, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the checkLinks.js tool on our actions workflow.
Change format of logged messages when run on GitHub Actions (i.e.
when the GITHUB_ACTIONS environment variable is true) so that
broken links are highlighted inline in pull requests.
Refs: #34787
Checklist