deps: update V8 to 4.6.85.28 - #3484
Conversation
Sorry, something went wrong.
|
Technically LGTM but if I read it right, this changes date parsing back from ES6 conforming to ES5. I understand that for Chromium not breaking the web is important but for us though, it's arguably a semver-major change... |
Sorry, something went wrong.
|
I understand that the change appeared with v8 4.6 so we don't have any release with it yet. |
Sorry, something went wrong.
|
This is why I think it's important to update before releasing v5.0.0. |
Sorry, something went wrong.
|
Oh hah, good point. Never mind I said that. EDIT: Double-checked that the change is not in 4.5 and it's not. |
Sorry, something went wrong.
Sorry, something went wrong.
This update fixes a breaking regression in the date parser. Ref: https://code.google.com/p/chromium/issues/detail?id=539813 Ref: https://code.google.com/p/chromium/issues/detail?id=543320 PR-URL: nodejs#3484 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This update fixes a breaking regression in the date parser. Ref: https://code.google.com/p/chromium/issues/detail?id=539813 Ref: https://code.google.com/p/chromium/issues/detail?id=543320 PR-URL: #3484 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This update fixes a breaking regression in the date parser.
Ref: https://code.google.com/p/chromium/issues/detail?id=539813
Ref: https://code.google.com/p/chromium/issues/detail?id=543320
cc @nodejs/v8