FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add Windows-specific info to `subprocess.kill` by joaolucasl · Pull Request #34867 · nodejs/node · GitHub

/ node Public

doc: add Windows-specific info to subprocess.kill - #34867

Merged
Trott merged 1 commit into
nodejs:masterfrom
joaolucasl:docs/windows-child-process-kill
Mar 30, 2021
ConversationCommits (1)ChecksFiles changed
Merged

doc: add Windows-specific info to subprocess.kill#34867
Trott merged 1 commit into
nodejs:masterfrom
joaolucasl:docs/windows-child-process-kill

Conversation

joaolucasl commented Aug 21, 2020

Copy link
Copy Markdown
Contributor

Clarify the inner workings of subprocess.kill() on Windows,since termination signals are not available there.

I used the the LibUV docs to make sure that this was the actual behaviour, after noticing the code on internal/child_process would ultimately call it via process_wrap.

Fixes: #34858

Checklist

nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Aug 21, 2020
joaolucasl mentioned this pull request Aug 21, 2020
Closed
1 task
juanarbol approved these changes Aug 21, 2020
View reviewed changes

juanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice.

Not a blocker: I'd put this just after the Linux specification and before code example.

s4m0r4m4 commented Aug 22, 2020

Copy link
Copy Markdown

Looks good to me, thanks!

targos commented Aug 22, 2020

Copy link
Copy Markdown
Member

@nodejs/child_process

joaolucasl force-pushed the docs/windows-child-process-kill branch from 8d40f81 to 28587cd Compare August 22, 2020 16:37

s4m0r4m4 commented Sep 9, 2020

Copy link
Copy Markdown

Who do we need to give the OK and merge this in? I see @jasnell approved it, not sure if he can merge it.

zenflow reviewed Sep 12, 2020
View reviewed changes
Comment thread doc/api/child_process.md Outdated

zenflow Sep 12, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should this say SIGINT and SIGTERM instead?
If I'm not mistaken, SIGINT isn't available here either.
And SIGKILL, if available, forcibly terminates (so it's unavailability doesn't help explain why child process must be forcefully terminated.. SIGKILL wouldn't be useful for avoiding forceful termination anyways).

bcoe mentioned this pull request Sep 13, 2020
Closed
4 tasks

aduh95 commented Nov 8, 2020

Copy link
Copy Markdown
Contributor

@joaolucasl This needs a rebase, and there is one comment left that needs to be addressed before landing.

aduh95 added the stalled Issues and PRs that are stalled. label Nov 8, 2020

github-actions Bot commented Nov 8, 2020

Copy link
Copy Markdown
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

joaolucasl commented Nov 9, 2020

Copy link
Copy Markdown
Contributor Author

Will update it this week.

Trott reviewed Nov 11, 2020
View reviewed changes
Comment thread doc/api/child_process.md Outdated
Trott reviewed Nov 11, 2020
View reviewed changes
Comment thread doc/api/child_process.md Outdated

PoojaDurgad commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

@joaolucasl - looks like this PR have gotten a little stuck. need a rebase to resolve git conflicts

Trott force-pushed the docs/windows-child-process-kill branch from 7160bc5 to c0ba12a Compare January 8, 2021 03:07

Trott commented Jan 8, 2021

Copy link
Copy Markdown
Member

I rebased, fixed the merge conflict, fixed the lint error, squashed, and force pushed.

zenflow reviewed Mar 25, 2021
View reviewed changes
Comment thread doc/api/child_process.md Outdated
joaolucasl force-pushed the docs/windows-child-process-kill branch from c0ba12a to 57f3583 Compare March 26, 2021 16:55

joaolucasl commented Mar 26, 2021

Copy link
Copy Markdown
Contributor Author

Sorry for the huge delay in updating this. Thanks @zenflow for the suggestion.

Ready for review!

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. review wanted PRs that need reviews. labels Mar 26, 2021
doc: add Windows-specific info to subprocess.kill()
504ed7c 
Clarify the inner workings of .kill on Windows,
since termination signals are not available there.

Fixes: nodejs#34858

PR-URL: nodejs#34867
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott force-pushed the docs/windows-child-process-kill branch from 57f3583 to 504ed7c Compare March 30, 2021 11:08

Trott commented Mar 30, 2021

Copy link
Copy Markdown
Member

Landed in 504ed7c

Trott merged commit 504ed7c into nodejs:master Mar 30, 2021
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
doc: add Windows-specific info to subprocess.kill()
13c3924 
Clarify the inner workings of .kill on Windows,
since termination signals are not available there.

Fixes: #34858

PR-URL: #34867
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Apr 4, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
doc: add Windows-specific info to subprocess.kill()
35a382e 
Clarify the inner workings of .kill on Windows,
since termination signals are not available there.

Fixes: #34858

PR-URL: #34867
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
joaolucasl deleted the docs/windows-child-process-kill branch June 11, 2021 12:56
sindresorhus mentioned this pull request Jul 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
juanarbol juanarbol approved these changes
+1 more reviewer
zenflow zenflow left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. review wanted PRs that need reviews. stalled Issues and PRs that are stalled. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: child_process.kill() on windows needs clarification
Back | FazBrowse Home | New Git URL