FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: test-npm fixes for npm3 by Fishrock123 · Pull Request #3489 · nodejs/node · GitHub

/ node Public

tools: test-npm fixes for npm3 - #3489

Closed
Fishrock123 wants to merge 0 commit into
nodejs:masterfrom
Fishrock123:test-npm-fixes-for-npm3
ConversationCommits (0)ChecksFiles changed
Closed

tools: test-npm fixes for npm3#3489
Fishrock123 wants to merge 0 commit into
nodejs:masterfrom
Fishrock123:test-npm-fixes-for-npm3

Conversation

Fishrock123 commented Oct 22, 2015

Copy link
Copy Markdown
Contributor

I feel better about doing it this way.

replaces #3308

See: #3308 (comment)

cc @nodejs/build or anyone elase: any sign-off will do.

Fishrock123 added test Issues and PRs related to the tests. npm Issues and PRs related to the npm client dependency or the npm registry. tools Issues and PRs related to the tools directory. labels Oct 22, 2015
Fishrock123 force-pushed the test-npm-fixes-for-npm3 branch from f69b0a0 to 6c9938b Compare October 22, 2015 17:32

rvagg commented Oct 22, 2015

Copy link
Copy Markdown
Member

lgtm, get it done and we'll shake it out in an RC

Fishrock123 pushed a commit that referenced this pull request Oct 22, 2015
tools: update test-npm to work with npm 3
349fbe9 
Refs: #3308
PR-URL: #3489
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123 added a commit that referenced this pull request Oct 22, 2015
tools: ensure npm always uses the local node
9b88864 
Refs: #3308
PR-URL: #3489
Reviewed-By: Rod Vagg <rod@vagg.org>
Fishrock123 force-pushed the test-npm-fixes-for-npm3 branch from 6c9938b to 9b88864 Compare October 22, 2015 17:51
Fishrock123 deleted the test-npm-fixes-for-npm3 branch October 22, 2015 17:51
rvagg pushed a commit that referenced this pull request Oct 22, 2015
tools: update test-npm to work with npm 3
3c3435d 
Refs: #3308
PR-URL: #3489
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123 added a commit that referenced this pull request Oct 22, 2015
tools: ensure npm always uses the local node
6e78382 
Refs: #3308
PR-URL: #3489
Reviewed-By: Rod Vagg <rod@vagg.org>
Fishrock123 mentioned this pull request Oct 22, 2015
Closed

MylesBorins commented Oct 23, 2015

Copy link
Copy Markdown
Contributor

should this be added to LTS?

/cc @jasnell

Fishrock123 commented Oct 23, 2015

Copy link
Copy Markdown
Contributor Author

@thealphanerd no, this is only for npm@3. v4 uses npm@2.

This was referenced Oct 27, 2015
Merged
Closed
rvagg mentioned this pull request Dec 17, 2015
Closed

MylesBorins commented Dec 29, 2015

Copy link
Copy Markdown
Contributor

@jasnell this is only useful for npm3... are we planning to backport that to lts?

Fishrock123 commented Jan 4, 2016

Copy link
Copy Markdown
Contributor Author

No, it shouldn't be backported.

MylesBorins mentioned this pull request Jan 14, 2016
Closed
This was referenced Apr 29, 2023
Open
Open
This was referenced Jun 22, 2023
Open
Open
This was referenced Jun 23, 2023
Open
Open
Open
leonardoadame mentioned this pull request Jul 9, 2023
Open
aliscco mentioned this pull request Oct 27, 2023
Open
aliscco mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 29, 2023
Open
Open
aliscco mentioned this pull request Dec 2, 2023
Open
leonardoadame mentioned this pull request Dec 3, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL