FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: make response.setTimeout() work by juanarbol · Pull Request #34913 · nodejs/node · GitHub

/ node Public

http: make response.setTimeout() work - #34913

Closed
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:juanarbol/incomingmessage-timeout
ConversationCommits (1)ChecksFiles changed
Closed

http: make response.setTimeout() work#34913
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:juanarbol/incomingmessage-timeout

Conversation

juanarbol commented Aug 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #33734

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, I just saw #33734 "inactive" but solved, just re-do what Ben did.

juanarbol requested review from bnoordhuis and lpinca August 24, 2020 21:15
juanarbol requested a review from a team as a code owner August 24, 2020 21:15

nodejs-github-bot commented Aug 24, 2020 •
edited by juanarbol
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Aug 24, 2020

aduh95 commented Aug 24, 2020

Copy link
Copy Markdown
Contributor

Why not include the original commit to credit the author?

juanarbol commented Aug 24, 2020

Copy link
Copy Markdown
Member Author

@aduh95 I don't have that git skill (yet), hold on. I'm doing that.

juanarbol force-pushed the juanarbol/incomingmessage-timeout branch from 0084931 to 9c588f2 Compare August 24, 2020 21:57

juanarbol commented Aug 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

@aduh95 I've cherry picked the @bnoordhuis commit (BTW sorry, I did not mean to take credits of anything), now the next question for Ben is if he wants this to be landed.

rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2020

nodejs-github-bot commented Aug 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32937/

nodejs-github-bot commented Aug 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32949/

github-actions Bot mentioned this pull request Aug 27, 2020
Open
10 tasks
lpinca reviewed Aug 27, 2020
View reviewed changes
Comment thread test/parallel/test-http-client-response-timeout.js Outdated
Comment thread test/parallel/test-http-client-response-timeout.js Outdated
juanarbol force-pushed the juanarbol/incomingmessage-timeout branch from 9c588f2 to 9755a47 Compare September 9, 2020 01:29
juanarbol requested a review from lpinca September 9, 2020 01:30
gengjiawen added needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Sep 12, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2020

nodejs-github-bot commented Sep 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33135/

juanarbol added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 12, 2020
juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2020

nodejs-github-bot commented Sep 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33291/

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2020

nodejs-github-bot commented Oct 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33399/

juanarbol added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 7, 2020
juanarbol pushed a commit to juanarbol/node that referenced this pull request Oct 7, 2020
http: make response.setTimeout() work
7b26322 
Fixes: nodejs#33734

PR-URL: nodejs#34913
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

juanarbol commented Oct 7, 2020

Copy link
Copy Markdown
Member Author

Landed in 7b26322

juanarbol closed this Oct 7, 2020
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
http: make response.setTimeout() work
2f13199 
Fixes: #33734

PR-URL: #34913
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
http: make response.setTimeout() work
d54a696 
Fixes: nodejs#33734

PR-URL: nodejs#34913
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
juanarbol deleted the juanarbol/incomingmessage-timeout branch January 19, 2021 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
trivikr trivikr approved these changes
bnoordhuis Awaiting requested review from bnoordhuis
+1 more reviewer
rickyes rickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http.IncomingMessage doesn't fire callback on 'timeout'

8 participants

Back | FazBrowse Home | New Git URL