FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update crypto.md by anlexN · Pull Request #34930 · nodejs/node · GitHub

/ node Public

Update crypto.md - #34930

Closed
anlexN wants to merge 1 commit into
nodejs:masterfrom
anlexN:patch-1
Closed

Update crypto.md#34930
anlexN wants to merge 1 commit into
nodejs:masterfrom
anlexN:patch-1

Conversation

anlexN commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

align to function signature

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

align to function signature
nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Aug 26, 2020
tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2020

Copy link
Copy Markdown
Collaborator

joyeecheung added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 2, 2020
rickyes added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2020
github-actions Bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 10, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/34930
✔  Done loading data for nodejs/node/pull/34930
----------------------------------- PR info ------------------------------------
Title      Update crypto.md (#34930)
Author     anlex N <1293006794@qq.com> (@anlexN, first-time contributor)
Branch     anlexN:patch-1 -> nodejs:master
Labels     author ready, crypto, doc
Commits    1
 - Update crypto.md
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/34930
Reviewed-By: Joyee Cheung 
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/34930
Reviewed-By: Joyee Cheung 
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Doc-only changes
   ℹ  This PR was created on Wed, 26 Aug 2020 09:29:44 GMT
   ✔  Approvals: 2
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/34930#pullrequestreview-476765948
   ✔  - Ricky Zhou (@rickyes): https://github.com/nodejs/node/pull/34930#pullrequestreview-486026424
--------------------------------------------------------------------------------
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch              master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 34930
✔  Downloaded patch to /home/runner/work/node/node/.ncu/34930/patch
--------------------------------------------------------------------------------
Applying: Update crypto.md
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
Update crypto.md

align to function signature

PR-URL: #34930
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Ricky Zhou 0x19951125@gmail.com

[master 792b08a8] Update crypto.md
Author: anlex N 1293006794@qq.com
Date: Wed Aug 26 17:26:54 2020 +0800
1 file changed, 4 insertions(+), 4 deletions(-)
✖ 792b08a8687906710f2fb57b214109e0c93d02b6
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 3:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Missing subsystem. subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.

gengjiawen pushed a commit that referenced this pull request Sep 30, 2020
PR-URL: #34930
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

Copy link
Copy Markdown
Member

Landed in c7e3b0b

gengjiawen closed this Sep 30, 2020

Copy link
Copy Markdown
Member

Thanks for the contribution 😃

danielleadams pushed a commit that referenced this pull request Oct 6, 2020
PR-URL: #34930
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams mentioned this pull request Oct 6, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#34930
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL