FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: fix upgrade to npm 3.3.6 by iarna · Pull Request #3494 · nodejs/node · GitHub

/ node Public

deps: fix upgrade to npm 3.3.6 - #3494

Closed
iarna wants to merge 1 commit into
nodejs:masterfrom
npm:fix-npm-3.3.6
ConversationCommits (1)ChecksFiles changed
Closed

deps: fix upgrade to npm 3.3.6#3494
iarna wants to merge 1 commit into
nodejs:masterfrom
npm:fix-npm-3.3.6

Conversation

iarna commented Oct 23, 2015

Copy link
Copy Markdown
Member

This adds the debug dep back in for npm@3.3.6. I'll PR separately for fixing the .gitigore to not cause this problem again. This will resolve the problem in #3493

iarna mentioned this pull request Oct 23, 2015
Closed

jbergstroem commented Oct 23, 2015

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/924/

Edit: fix CI link.
Edit2: had to cancel and resubmit, link updated.

jbergstroem added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 23, 2015

evanlucas commented Oct 23, 2015

Copy link
Copy Markdown
Contributor

CI looks good (minus the tests that have been failing pretty consistently lately)

LGTM

jasnell commented Oct 23, 2015

Copy link
Copy Markdown
Member

LGTM. Will get this landed now so CI can get back on track

jasnell pushed a commit that referenced this pull request Oct 23, 2015
deps: fix upgrade to npm 3.3.6
68471dd 
41923c0 broke things. This fixes them.

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #3494

jasnell commented Oct 23, 2015

Copy link
Copy Markdown
Member

Landed in 68471dd

jasnell closed this Oct 23, 2015
rvagg pushed a commit that referenced this pull request Oct 26, 2015
deps: fix upgrade to npm 3.3.6
f76af49 
41923c0 broke things. This fixes them.

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #3494
This was referenced Oct 27, 2015
Merged
Closed
Closed
rvagg mentioned this pull request Dec 17, 2015
Closed
MylesBorins mentioned this pull request Jan 14, 2016
Closed
This was referenced Apr 29, 2023
Open
Open
This was referenced Jun 22, 2023
Open
Open
Open
Open
Open
leonardoadame mentioned this pull request Jul 9, 2023
Open
aliscco mentioned this pull request Oct 27, 2023
Open
aliscco mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 29, 2023
Open
Open
aliscco mentioned this pull request Dec 2, 2023
Open
leonardoadame mentioned this pull request Dec 3, 2023
Open
wraithgar deleted the fix-npm-3.3.6 branch June 26, 2025 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL