doc: add missing DEP ID for 'new crypto.Certificate()' - #34940
Closed
BethGriggs wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
richardlau
approved these changes
Aug 26, 2020
Copy link
Copy Markdown
Member
|
We should fast track so the number is assigned for the 14.9.0 release. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Side thought, our process is to update the DEP0XXX value when we land the PR on master. Which, I think, means we cannot use the commit queue to land new deprecations just yet - possibly a future enhancement? |
Sorry, something went wrong.
cjihrig
approved these changes
Aug 26, 2020
14 tasks
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/34940 ✔ Done loading data for nodejs/node/pull/34940 ----------------------------------- PR info ------------------------------------ Title doc: add missing DEP ID for 'new crypto.Certificate()' (#34940) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch BethGriggs:missing-dep -> nodejs:master Labels deprecations, doc, fast-track Commits 1 - doc: add missing DEP ID for 'new crypto.Certificate()' Committers 1 - Beth Griggs PR-URL: https://github.com/nodejs/node/pull/34940 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/34940 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ✖ No CI runs detected ℹ This PR was created on Wed, 26 Aug 2020 21:22:57 GMT ✔ Approvals: 2 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/34940#pullrequestreview-475870190 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/34940#pullrequestreview-475910119 ℹ This PR is being fast-tracked -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
Sorry, something went wrong.
BethGriggs
added a commit
that referenced
this pull request
Aug 26, 2020
PR-URL: #34940 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Copy link
Copy Markdown
Contributor
|
(fyi we have a fix on ncu for the No CI runs detected error when landing doc-only changes, we just need to publish a new version) |
Sorry, something went wrong.
BethGriggs
added a commit
that referenced
this pull request
Aug 26, 2020
PR-URL: #34940 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist