FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: improve Writable.destroy performance by ronag · Pull Request #35067 · nodejs/node · GitHub

/ node Public

stream: improve Writable.destroy performance - #35067

Closed
ronag wants to merge 4 commits into
nodejs:masterfrom
nxtedition:writable-destroy-perf
ConversationCommits (4)ChecksFiles changed
Closed

stream: improve Writable.destroy performance#35067
ronag wants to merge 4 commits into
nodejs:masterfrom
nxtedition:writable-destroy-perf

Conversation

ronag commented Sep 5, 2020

Copy link
Copy Markdown
Member

Avoid nextTick if there are no pending callbacks.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

stream: improbe Writable.destroy performance
6734876 
Avoid nextTick if there are no pending callbacks.
ronag added the stream Issues and PRs related to the stream subsystem. label Sep 5, 2020

ronag commented Sep 5, 2020

Copy link
Copy Markdown
Member Author

@nodejs/streams

mcollina approved these changes Sep 5, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Sep 5, 2020
ronag changed the title stream: improbe Writable.destroy performance stream: improve Writable.destroy performance Sep 5, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2020

nodejs-github-bot commented Sep 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33069/

addaleax approved these changes Sep 5, 2020
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Feel free to add a comment that this condition is equivalent to no callbacks being pending :)

ronag force-pushed the writable-destroy-perf branch from 7588c63 to ab7b73d Compare September 5, 2020 17:12
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2020

nodejs-github-bot commented Sep 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33072/

nodejs-github-bot commented Sep 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33074/

ronag added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 7, 2020
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2020

nodejs-github-bot commented Sep 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33085/

nodejs-github-bot commented Sep 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33086/

ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 7, 2020
github-actions Bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 7, 2020

github-actions Bot commented Sep 7, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/35067
✔  Done loading data for nodejs/node/pull/35067
----------------------------------- PR info ------------------------------------
Title      stream: improve Writable.destroy performance (#35067)
Author     Robert Nagy  (@ronag)
Branch     ronag:writable-destroy-perf -> nodejs:master
Labels     author ready, stream
Commits    4
 - stream: improbe Writable.destroy performance
 - fixup
 - fixup
 - fixup
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/35067
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35067
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - fixup
   ⚠  - fixup
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2020-09-07T09:00:43Z: https://ci.nodejs.org/job/node-test-pull-request/33086/
- Querying data for job/node-test-pull-request/33086/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Sat, 05 Sep 2020 11:51:48 GMT
   ✔  Approvals: 4
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/35067#pullrequestreview-483051355
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/35067#pullrequestreview-483067062
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35067#pullrequestreview-483072059
   ✔  - Ricky Zhou (@rickyes): https://github.com/nodejs/node/pull/35067#pullrequestreview-483143528
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

addaleax added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 7, 2020
github-actions Bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 7, 2020

github-actions Bot commented Sep 7, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/35067
✔  Done loading data for nodejs/node/pull/35067
----------------------------------- PR info ------------------------------------
Title      stream: improve Writable.destroy performance (#35067)
Author     Robert Nagy  (@ronag)
Branch     ronag:writable-destroy-perf -> nodejs:master
Labels     author ready, stream
Commits    4
 - stream: improbe Writable.destroy performance
 - fixup
 - fixup
 - fixup
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/35067
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35067
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
--------------------------------------------------------------------------------
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2020-09-07T14:21:04Z: https://ci.nodejs.org/job/node-test-pull-request/33086/
- Querying data for job/node-test-pull-request/33086/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Sat, 05 Sep 2020 11:51:48 GMT
   ✔  Approvals: 4
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/35067#pullrequestreview-483051355
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/35067#pullrequestreview-483593618
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35067#pullrequestreview-483072059
   ✔  - Ricky Zhou (@rickyes): https://github.com/nodejs/node/pull/35067#pullrequestreview-483143528
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

ronag commented Sep 7, 2020

Copy link
Copy Markdown
Member Author

@nodejs/build a little trouble landing with the GH action? Something you want to take a look at or should I just land this manually?

addaleax mentioned this pull request Sep 7, 2020
Merged
Trott pushed a commit to Trott/io.js that referenced this pull request Sep 7, 2020
stream: improve Writable.destroy performance
e0d3b75 
Avoid nextTick if there are no pending callbacks.

PR-URL: nodejs#35067
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

Trott commented Sep 7, 2020

Copy link
Copy Markdown
Member

Landed in e0d3b75

Trott closed this Sep 7, 2020

ljharb commented Sep 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@ronag have had you checked the "allow edits" box on the PR?

Trott commented Sep 7, 2020

Copy link
Copy Markdown
Member

Sorry if I stomped all over the "land manually? change edit permissions? something else?" conversation by landing this. Wasn't my intention. I figured @ronag probably would prefer a resolution (landing) over some back-and-forth about this, but maybe I'm wrong.

ljharb commented Sep 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@Trott imo it should always be 100% ok to land over this particular X, just trying to figure out the forensics on the implication that it was unavoidable.

ruyadorno commented Sep 15, 2020

Copy link
Copy Markdown
Member

this doesn't land cleanly on v14.x-staging adding a request to backport

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
stream: improve Writable.destroy performance
079af89 
Avoid nextTick if there are no pending callbacks.

PR-URL: nodejs#35067
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Linkgoron mentioned this pull request Apr 10, 2021
Closed
targos added dont-land-on-v14.x and removed backport-requested-v14.x author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
+1 more reviewer
rickyes rickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL