FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: improve tests for util.inherits by targos · Pull Request #3507 · nodejs/node · GitHub

/ node Public

test: improve tests for util.inherits - #3507

Closed
targos wants to merge 2 commits into
nodejs:masterfrom
targos:better-test-inherits
ConversationCommits (2)ChecksFiles changed
Closed

test: improve tests for util.inherits#3507
targos wants to merge 2 commits into
nodejs:masterfrom
targos:better-test-inherits

Conversation

targos commented Oct 24, 2015

Copy link
Copy Markdown
Member

inherits is used in lib and tests but its functionality itself is not
tested yet.

This is preparation for PR #3455 so I can add more tests to it.

test: improve tests for util.inherits
1abc568 
inherits is used in lib and tests but its functionality itself is not
tested yet.
targos added the test Issues and PRs related to the tests. label Oct 24, 2015

targos commented Oct 24, 2015

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/943/

thefourtheye commented Oct 24, 2015

Copy link
Copy Markdown
Contributor

inherits actually sets a property called super_. Can you throw in some asserts to check that as well?

targos commented Oct 24, 2015

Copy link
Copy Markdown
Member Author

Good point, done!

thefourtheye reviewed Oct 24, 2015
View reviewed changes
Comment thread test/parallel/test-util.js

thefourtheye Oct 24, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this is removed in favour of #3455?

targos Oct 24, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not really. I think this line was added to make sure inherits doesn't throw when two constructors are passed to it. Now it is implicitly tested with this PR.

thefourtheye Oct 24, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, okay. Thanks :)

thefourtheye commented Oct 24, 2015

Copy link
Copy Markdown
Contributor

LGTM

mscdex added the util Issues and PRs related to the built-in util module. label Oct 24, 2015
targos added a commit that referenced this pull request Oct 26, 2015
test: improve tests for util.inherits
df738ac 
inherits is used in lib and tests but its functionality itself is not
tested yet.

PR-URL: #3507
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

targos commented Oct 26, 2015

Copy link
Copy Markdown
Member Author

Thanks, landed in df738ac.

targos closed this Oct 26, 2015
targos deleted the better-test-inherits branch October 26, 2015 08:39
targos added a commit that referenced this pull request Oct 26, 2015
test: improve tests for util.inherits
1a968e6 
inherits is used in lib and tests but its functionality itself is not
tested yet.

PR-URL: #3507
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
rvagg mentioned this pull request Oct 27, 2015
Merged

targos commented Oct 27, 2015

Copy link
Copy Markdown
Member Author

@jasnell I think this can go in v4.x

targos added a commit that referenced this pull request Oct 28, 2015
test: improve tests for util.inherits
12d8385 
inherits is used in lib and tests but its functionality itself is not
tested yet.

PR-URL: #3507
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

jasnell commented Oct 28, 2015

Copy link
Copy Markdown
Member

Landed in v4.x-staging in 12d8385

rvagg mentioned this pull request Oct 28, 2015
Closed
targos added a commit that referenced this pull request Oct 29, 2015
test: improve tests for util.inherits
32149ca 
inherits is used in lib and tests but its functionality itself is not
tested yet.

PR-URL: #3507
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This was referenced Apr 29, 2023
Open
Open
This was referenced Jun 22, 2023
Open
Open
Open
Open
aliscco mentioned this pull request Jun 26, 2023
Open
leonardoadame mentioned this pull request Jul 9, 2023
Open
aliscco mentioned this pull request Oct 27, 2023
Open
aliscco mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 29, 2023
Open
Open
aliscco mentioned this pull request Dec 2, 2023
Open
leonardoadame mentioned this pull request Dec 3, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL