FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

v14.10.1 proposal by richardlau · Pull Request #35137 · nodejs/node · GitHub

/ node Public

v14.10.1 proposal - #35137

Merged
richardlau merged 3 commits into
v14.xfrom
v14.10.1-proposal
Sep 10, 2020
ConversationCommits (3)ChecksFiles changed
Merged

v14.10.1 proposal#35137
richardlau merged 3 commits into
v14.xfrom
v14.10.1-proposal

Conversation

richardlau commented Sep 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Notable Changes

Node.js 14.10.0 included a streams regression with async generators
and a docs rendering regression that are being fixed in this release.

Commits

  • [3c92f93b44] - doc: restore color for visited links (Rich Trott) #35108
  • [0f94c6b4e4] - Revert "stream: simpler and faster Readable async iterator" (Richard Lau)

@nodejs/streams @nodejs/tsc @nodejs/releasers
This proposes reverting 4bb4007 to address #35116. It sounds like more time is needed to otherwise fix the issues in both the streams code and in got and I think it would be better for us to get v14.x into a stable state ahead of Tuesday's security release.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v14.x labels Sep 10, 2020
richardlau added a commit that referenced this pull request Sep 10, 2020
2020-09-10, Version 14.10.1 (Current)
d31b12d 
Notable changes:

Node.js 14.10.0 included a streams regression that is being fixed in
this release.

PR-URL: #35137

nodejs-github-bot commented Sep 10, 2020 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33121/
citgm got CI: https://ci.nodejs.org/job/citgm-smoker/2465/
citgm got with v14.10.0 for comparison: https://ci.nodejs.org/job/citgm-smoker/2466/

richardlau mentioned this pull request Sep 10, 2020
Closed
mmarchini approved these changes Sep 10, 2020
View reviewed changes

mmarchini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reverting the commit so we have more time to work on a long term solution sgtm

mcollina approved these changes Sep 10, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

Trott approved these changes Sep 10, 2020
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Would love to get #35108 in this release as well.

Trott mentioned this pull request Sep 10, 2020
Closed
2 tasks
doc: restore color for visited links
3c92f93 
A previous change altered the rendering of visited links. This restores
it.

PR-URL: #35108
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
2020-09-10, Version 14.10.1 (Current)
4c2b513 
Notable changes:

Node.js 14.10.0 included a streams regression with async generators
and a docs rendering regression that are being fixed in this release.

PR-URL: #35137

nodejs-github-bot commented Sep 10, 2020 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33123/ (✔️)
Release-CI: https://ci-release.nodejs.org/job/iojs+release/6304/

richardlau commented Sep 10, 2020

Copy link
Copy Markdown
Member Author

LGTM. Would love to get #35108 in this release as well.

@Trott Added #35108.

Giotino mentioned this pull request Sep 10, 2020
Merged
richardlau added a commit that referenced this pull request Sep 10, 2020
Working on v14.10.2
8d1d5f9 
PR-URL: #35137
richardlau merged commit 4c2b513 into v14.x Sep 10, 2020
richardlau added a commit that referenced this pull request Sep 10, 2020
2020-09-10, Version 14.10.1 (Current)
b7f3e83 
Notable changes:

Node.js 14.10.0 included a streams regression with async generators
and a docs rendering regression that are being fixed in this release.

PR-URL: #35137
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Sep 10, 2020
Blog: v14.10.1 release post
27d39c9 
Refs: nodejs/node#35137
richardlau mentioned this pull request Sep 10, 2020
Merged
richardlau added a commit to nodejs/nodejs.org that referenced this pull request Sep 10, 2020
Blog: v14.10.1 release post (#3368)
80dbed6 
Refs: nodejs/node#35137

richardlau commented Sep 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

There was a release process issue that seems to have resulted in the latest symlinks

not pointing to the new release. The actual files in https://nodejs.org/download/release/v14.10.1/ look okay.

FYI @ljharb in case this affects nvm

I've raised nodejs/build#2432.

richardlau deleted the v14.10.1-proposal branch September 10, 2020 16:19

ljharb commented Sep 10, 2020

Copy link
Copy Markdown
Member

Luckily nvm doesn’t use those :-) thanks for the ping.

Flarna commented Sep 10, 2020

Copy link
Copy Markdown
Member

nvm for windows seems to be effected and the docs on website.

This was referenced Sep 10, 2020
Closed
Closed
Closed

richardlau commented Sep 11, 2020

Copy link
Copy Markdown
Member Author

Symlinks have now been fixed.

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
2020-09-10, Version 14.10.1 (Current)
ff499e1 
Notable changes:

Node.js 14.10.0 included a streams regression with async generators
and a docs rendering regression that are being fixed in this release.

PR-URL: nodejs#35137
targos added release Issues and PRs related to Node.js releases. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
Trott Trott approved these changes
ronag ronag approved these changes
BethGriggs BethGriggs approved these changes
+2 more reviewers
targos targos approved these changes
mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL