FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove http2 non-link anchor tags by Trott · Pull Request #35161 · nodejs/node · GitHub

/ node Public

doc: remove http2 non-link anchor tags - #35161

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:http2-ids
Sep 14, 2020
Merged

doc: remove http2 non-link anchor tags#35161
Trott merged 1 commit into
nodejs:masterfrom
Trott:http2-ids

Conversation

Trott commented Sep 12, 2020

Copy link
Copy Markdown
Member

Headers have ids automatically assigned. Removed ad hoc ids using anchor
tags that aren't links.

Checklist

Trott requested review from a team as code owners September 12, 2020 03:26

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Sep 12, 2020

Trott commented Sep 12, 2020

Copy link
Copy Markdown
Member Author

@DerekNonGeneric @aduh95

Copy link
Copy Markdown
Member

I kind of wish we’d go into the opposite direction more often – these anchor tags allow creating permanently functional links from other websites to the documentation, while the automatically generated anchors can easily change even when only a minor change to the header text was performed and break those links. I would keep them.

Trott commented Sep 12, 2020

Copy link
Copy Markdown
Member Author

I kind of wish we’d go into the opposite direction more often – these anchor tags allow creating permanently functional links from other websites to the documentation, while the automatically generated anchors can easily change even when only a minor change to the header text was performed and break those links. I would keep them.

I can definitely support that to accommodate links from external pages, but these were apparently created to have links from within the page, and I'm not sure we want to encourage that.

Trott commented Sep 14, 2020

Copy link
Copy Markdown
Member Author

Landed in b569376

Trott merged commit b569376 into nodejs:master Sep 14, 2020
Trott deleted the http2-ids branch September 14, 2020 04:43
Headers have ids automatically assigned. Removed ad hoc ids using anchor
tags that aren't links.

PR-URL: nodejs#35161
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Copy link
Copy Markdown
Member

this change doesn't land cleanly on v14.x, should it be backported?

Trott added a commit to Trott/io.js that referenced this pull request Sep 25, 2020
Headers have ids automatically assigned. Removed ad hoc ids using anchor
tags that aren't links.

PR-URL: nodejs#35161
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott commented Sep 25, 2020

Copy link
Copy Markdown
Member Author

this change doesn't land cleanly on v14.x, should it be backported?

@ruyadorno Backport in #35334.

MylesBorins pushed a commit that referenced this pull request Sep 29, 2020
Headers have ids automatically assigned. Removed ad hoc ids using anchor
tags that aren't links.

Backport-PR-URL: #35334
PR-URL: #35161
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Sep 29, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Headers have ids automatically assigned. Removed ad hoc ids using anchor
tags that aren't links.

PR-URL: nodejs#35161
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL