| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Review requested:
|
Sorry, something went wrong.
Sorry, something went wrong.
|
I kind of wish we’d go into the opposite direction more often – these anchor tags allow creating permanently functional links from other websites to the documentation, while the automatically generated anchors can easily change even when only a minor change to the header text was performed and break those links. I would keep them. |
Sorry, something went wrong.
I can definitely support that to accommodate links from external pages, but these were apparently created to have links from within the page, and I'm not sure we want to encourage that. |
Sorry, something went wrong.
Headers have ids automatically assigned. Removed ad hoc ids using anchor tags that aren't links. PR-URL: nodejs#35161 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
this change doesn't land cleanly on v14.x, should it be backported? |
Sorry, something went wrong.
Headers have ids automatically assigned. Removed ad hoc ids using anchor tags that aren't links. PR-URL: nodejs#35161 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno Backport in #35334. |
Sorry, something went wrong.
Headers have ids automatically assigned. Removed ad hoc ids using anchor tags that aren't links. PR-URL: nodejs#35161 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
| Back | FazBrowse Home | New Git URL |
Headers have ids automatically assigned. Removed ad hoc ids using anchor
tags that aren't links.
Checklist