FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update process.release by schamberg97 · Pull Request #35167 · nodejs/node · GitHub

/ node Public

doc: update process.release - #35167

Merged
Trott merged 1 commit into
nodejs:masterfrom
schamberg97:master
Sep 14, 2020
ConversationCommits (1)ChecksFiles changed
Merged

doc: update process.release#35167
Trott merged 1 commit into
nodejs:masterfrom
schamberg97:master

Conversation

schamberg97 commented Sep 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Process.release doc is severely outdated. This PR includes info about LTS releases 10 and 12.

Checklist

nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Sep 12, 2020
mscdex reviewed Sep 12, 2020
View reviewed changes
Comment thread doc/api/process.md Outdated

mscdex Sep 12, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If we're not going to maintain a list of all possible values, then I think we should change the preceding wording here from "Currently the valid values are:" to something like "Valid values may include:" to indicate that the following list is a subset. While "Argon" and others may no longer be supported they are still technically LTS release lines that someone could encounter.

schamberg97 Sep 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How about "Valid values include the LTS Release Codenames (including those that are no longer supported). A non-exhaustive example of these codenames includes:" ?

schamberg97 Sep 12, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps the links to Release schedule and Changelogs on Github should also be included?

addaleax Sep 12, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@schamberg97 That sounds good, feel free to add those 🙂

schamberg97 Sep 12, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'll do it, but I am away from computer until midgnight

addaleax Sep 12, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We currently have a waiting period of 48 hours before we merge any non-trivial PR anyway, so take your time :)

schamberg97 Sep 14, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry for the delay, had problems with my personal OSS project that was a bigger priority for me. This should probably be reviewed again, just in case

Trott reviewed Sep 14, 2020
View reviewed changes
Comment thread doc/api/process.md Outdated
Trott approved these changes Sep 14, 2020
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me, with or without the one suggestion I made.

Trott merged commit 571dff8 into nodejs:master Sep 14, 2020

Trott commented Sep 14, 2020

Copy link
Copy Markdown
Member

Landed in 571dff8

Trott commented Sep 14, 2020

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉

doc: update process.release
571dff8 
`process.release` documentation is out of date. This commit makes it up
to date.

PR-URL: #35167
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2020
doc: update process.release
32d1731 
`process.release` documentation is out of date. This commit makes it up
to date.

PR-URL: #35167
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno mentioned this pull request Sep 21, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
doc: update process.release
d94dac4 
`process.release` documentation is out of date. This commit makes it up
to date.

PR-URL: #35167
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
doc: update process.release
d9edc24 
`process.release` documentation is out of date. This commit makes it up
to date.

PR-URL: nodejs#35167
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
panva mentioned this pull request Oct 25, 2022
Closed
wedataintelligence mentioned this pull request Nov 30, 2023
Open
aliceUnhinged613 mentioned this pull request Nov 30, 2023
Open
baby636 mentioned this pull request Dec 1, 2023
Open
aliceUnhinged613 mentioned this pull request May 13, 2024
Open
molllyn1 mentioned this pull request May 13, 2024
Open
ron-a20 mentioned this pull request May 13, 2024
Open
137717unity mentioned this pull request May 14, 2024
Open
baby636 mentioned this pull request May 14, 2024
Open
wedataintelligence mentioned this pull request May 14, 2024
Open
aliceUnhinged613 mentioned this pull request May 15, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
richardlau richardlau approved these changes
gireeshpunathil gireeshpunathil approved these changes
mscdex Awaiting requested review from mscdex
addaleax Awaiting requested review from addaleax

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL