doc: update attributes used by n-api samples - #35220
Merged
mhdawson merged 1 commit intoSep 18, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Update n-api samples to create object properties matching to the JS defaults. Using non configurable, non writable properties has its usecases but the JS default for class methods is `configurable` and `writable`. Js properties set by JS code `obj.prop = val` are `configurable`, `writable` and `enumerable`.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
crypt096
approved these changes
Sep 16, 2020
gabrielschulhof
approved these changes
Sep 18, 2020
mhdawson
approved these changes
Sep 18, 2020
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks for contributing this!
Sorry, something went wrong.
ruyadorno
pushed a commit
that referenced
this pull request
Sep 21, 2020
Update n-api samples to create object properties matching to the JS defaults. Using non configurable, non writable properties has its usecases but the JS default for class methods is `configurable` and `writable`. Js properties set by JS code `obj.prop = val` are `configurable`, `writable` and `enumerable`.
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Update n-api samples to create object properties matching to the JS defaults. Using non configurable, non writable properties has its usecases but the JS default for class methods is `configurable` and `writable`. Js properties set by JS code `obj.prop = val` are `configurable`, `writable` and `enumerable`.
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Update n-api samples to create object properties matching to the JS defaults. Using non configurable, non writable properties has its usecases but the JS default for class methods is `configurable` and `writable`. Js properties set by JS code `obj.prop = val` are `configurable`, `writable` and `enumerable`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update n-api samples to create object properties matching to the JS defaults.
Using non configurable, non writable properties has its usecases but the JS default for class methods is configurable and writable. Js properties set by JS code obj.prop = val are configurable, writable and enumerable.
Refs: nodejs/node-addon-api#811
Refs: #35214