doc: put release script specifics in details - #35260
Closed
MylesBorins wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
richardlau
reviewed
Sep 18, 2020
Comment thread
doc/guides/releases.md
Outdated
MylesBorins
force-pushed
the
release-details
branch
3 times, most recently
from
bfd358e to
490d54a
Compare
September 18, 2020 17:06
Listing all the steps can be confusing an make it seem like the releaser is meant to run each of these steps manually. In fact I personally did that my first release. Let's put those steps in a details block to make it more obvious that it is informational and not steps to follow
MylesBorins
force-pushed
the
release-details
branch
from
490d54a to
5f121c9
Compare
September 18, 2020 17:07
richardlau
approved these changes
Sep 18, 2020
ruyadorno
approved these changes
Sep 18, 2020
watilde
approved these changes
Sep 19, 2020
addaleax
approved these changes
Sep 20, 2020
Comment thread
doc/guides/releases.md
Co-authored-by: Anna Henningsen <github@addaleax.net>
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35260 ✔ Done loading data for nodejs/node/pull/35260 ----------------------------------- PR info ------------------------------------ Title doc: put release script specifics in details (#35260) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MylesBorins:release-details -> nodejs:master Labels author ready, doc Commits 2 - doc: put release script specifics in details - Update doc/guides/releases.md Committers 2 - Myles Borins - GitHub PR-URL: https://github.com/nodejs/node/pull/35260 Reviewed-By: Richard Lau Reviewed-By: Ruy Adorno Reviewed-By: Daijiro Wachi Reviewed-By: Anna Henningsen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35260 Reviewed-By: Richard Lau Reviewed-By: Ruy Adorno Reviewed-By: Daijiro Wachi Reviewed-By: Anna Henningsen -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - Update doc/guides/releases.md ✖ Last GitHub CI failed ℹ Doc-only changes ℹ This PR was created on Fri, 18 Sep 2020 16:57:12 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35260#pullrequestreview-491687709 ✔ - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/35260#pullrequestreview-491743410 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/35260#pullrequestreview-491973533 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/35260#pullrequestreview-492198767 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
Sorry, something went wrong.
targos
approved these changes
Sep 21, 2020
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35260 ✔ Done loading data for nodejs/node/pull/35260 ----------------------------------- PR info ------------------------------------ Title doc: put release script specifics in details (#35260) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MylesBorins:release-details -> nodejs:master Labels author ready, doc Commits 2 - doc: put release script specifics in details - Update doc/guides/releases.md Committers 2 - Myles Borins - GitHub PR-URL: https://github.com/nodejs/node/pull/35260 Reviewed-By: Richard Lau Reviewed-By: Ruy Adorno Reviewed-By: Daijiro Wachi Reviewed-By: Anna Henningsen Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35260 Reviewed-By: Richard Lau Reviewed-By: Ruy Adorno Reviewed-By: Daijiro Wachi Reviewed-By: Anna Henningsen Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ✖ GitHub CI is still running ℹ Doc-only changes ℹ This PR was created on Fri, 18 Sep 2020 16:57:12 GMT ✔ Approvals: 5 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35260#pullrequestreview-491687709 ✔ - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/35260#pullrequestreview-491743410 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/35260#pullrequestreview-491973533 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/35260#pullrequestreview-492198767 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/35260#pullrequestreview-492875667 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
fyi commit queue won't work because there's a commit that neither passes our checks nor is a fixup! commit. |
Sorry, something went wrong.
MylesBorins
added a commit
that referenced
this pull request
Sep 21, 2020
Listing all the steps can be confusing an make it seem like the releaser is meant to run each of these steps manually. In fact I personally did that my first release. Let's put those steps in a details block to make it more obvious that it is informational and not steps to follow PR-URL: #35260 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Copy link
Copy Markdown
Contributor
Author
|
@mmarchini ahhhh. That commit was autogenerate via suggestions. I wonder if there is a way we could auto fixup those kinds of generated commits Landed in d71b467 |
Sorry, something went wrong.
MylesBorins
added a commit
that referenced
this pull request
Sep 24, 2020
Listing all the steps can be confusing an make it seem like the releaser is meant to run each of these steps manually. In fact I personally did that my first release. Let's put those steps in a details block to make it more obvious that it is informational and not steps to follow PR-URL: #35260 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
MylesBorins
added a commit
that referenced
this pull request
Nov 3, 2020
Listing all the steps can be confusing an make it seem like the releaser is meant to run each of these steps manually. In fact I personally did that my first release. Let's put those steps in a details block to make it more obvious that it is informational and not steps to follow PR-URL: #35260 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
MylesBorins
added a commit
that referenced
this pull request
Nov 16, 2020
Listing all the steps can be confusing an make it seem like the releaser is meant to run each of these steps manually. In fact I personally did that my first release. Let's put those steps in a details block to make it more obvious that it is informational and not steps to follow PR-URL: #35260 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Listing all the steps can be confusing an make it seem like the releaser is meant to run each of these steps manually. In fact I personally did that my first release. Let's put those steps in a details block to make it more obvious that it is informational and not steps to follow PR-URL: nodejs#35260 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listing all the steps can be confusing an make it seem like
the releaser is meant to run each of these steps manually. In fact
I personally did that my first release.
Let's put those steps in a details block to make it more obvious
that it is informational and not steps to follow