FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add `socket.readyState` by clarkkozak · Pull Request #35262 · nodejs/node · GitHub

/ node Public

doc: add socket.readyState - #35262

Merged
Trott merged 1 commit into
nodejs:masterfrom
clarkkozak:net-doc-readyState
Sep 23, 2020
ConversationCommits (1)ChecksFiles changed
Merged

doc: add socket.readyState#35262
Trott merged 1 commit into
nodejs:masterfrom
clarkkozak:net-doc-readyState

Conversation

clarkkozak commented Sep 18, 2020

Copy link
Copy Markdown
Contributor

This PR adds description of socket.readyState net documentation

Note that the readyState property was added in v0.5.0: e697cfb

Checklist
  • documentation is changed or added

clarkkozak requested a review from a team as a code owner September 18, 2020 21:30

nodejs-github-bot commented Sep 18, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Sep 18, 2020

clarkkozak commented Sep 18, 2020

Copy link
Copy Markdown
Contributor Author

Also it is still in the current version of Node:

node/lib/net.js

Line 524 in c66e647

ObjectDefineProperty(Socket.prototype, 'readyState', {

clarkkozak commented Sep 18, 2020

Copy link
Copy Markdown
Contributor Author

I'm unsure on how to add it to the navigation properly. If someone can advise on how to do so that would be awesome.

addaleax approved these changes Sep 20, 2020
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This will automatically be added to the table of contents, nothing to take care of there :)

Comment thread doc/api/net.md Outdated

clarkkozak commented Sep 20, 2020

Copy link
Copy Markdown
Contributor Author

This will automatically be added to the table of contents, nothing to take care of there :)

Right on! Thank you!

lpinca approved these changes Sep 20, 2020
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with @addaleax's comment addressed.

doc: add socket.readyState
81379d1 
+ description of `socket.readyState`

Note: YAML tag found in commit e697cfb

Co-authored-by: Michael Auderer <mike@silverstone.io>

PR-URL: #35262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott merged commit 81379d1 into nodejs:master Sep 23, 2020

Trott commented Sep 23, 2020

Copy link
Copy Markdown
Member

Landed in 81379d1.

Thanks for the contribution! 🎉

clarkkozak commented Sep 23, 2020

Copy link
Copy Markdown
Contributor Author

Landed in 81379d1.

Thanks for the contribution! 🎉

Right on! Thank you for being open source!

Take care y'all!

MylesBorins pushed a commit that referenced this pull request Sep 24, 2020
doc: add socket.readyState
ec6b78a 
+ description of `socket.readyState`

Note: YAML tag found in commit e697cfb

Co-authored-by: Michael Auderer <mike@silverstone.io>

PR-URL: #35262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Sep 29, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
doc: add socket.readyState
d3d7e03 
+ description of `socket.readyState`

Note: YAML tag found in commit e697cfb

Co-authored-by: Michael Auderer <mike@silverstone.io>

PR-URL: nodejs#35262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL