FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: put landing specifics in details tag by Trott · Pull Request #35296 · nodejs/node · GitHub

/ node Public

doc: put landing specifics in details tag - #35296

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:details-collab-guide
Sep 25, 2020
ConversationCommits (1)ChecksFiles changed
Merged

doc: put landing specifics in details tag#35296
Trott merged 1 commit into
nodejs:masterfrom
Trott:details-collab-guide

Conversation

Trott commented Sep 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Showing all the steps isn't usually useful and in makes it seem like the
collaborator is meant to follow the manual steps. I've seen this happen
during at least one onboarding. The section is also a bit long to
comfortably scroll over quickly to find the next section.

Let's put those steps in a details block to make it more obvious that it
is there for unusual situations only.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Sep 22, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 22, 2020
codebytere reviewed Sep 22, 2020
View reviewed changes
Comment thread doc/guides/collaborator-guide.md Outdated
mhdawson approved these changes Sep 22, 2020
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Trott commented Sep 25, 2020
View reviewed changes
Comment thread doc/guides/collaborator-guide.md Outdated
Trott commented Sep 25, 2020
View reviewed changes
Comment thread doc/guides/collaborator-guide.md Outdated
Trott commented Sep 25, 2020
View reviewed changes
Comment thread doc/guides/collaborator-guide.md Outdated
doc: revise introductory child_process text
52dd524 
This consolidates information about Windows environment variables and
has a few other smaller improvements (punctuation, present tense, etc.).

Co-authored-by: Shelley Vohr <codebytere@gmail.com>

PR-URL: nodejs#35296
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Trott force-pushed the details-collab-guide branch from 882e239 to 52dd524 Compare September 25, 2020 14:43
Trott merged commit 52dd524 into nodejs:master Sep 25, 2020
Trott deleted the details-collab-guide branch September 25, 2020 14:44

Trott commented Sep 25, 2020

Copy link
Copy Markdown
Member Author

Whoops, I messed up and landed the wrong thing. Force pushed it out, but now this says it's merged. Will try to recover it and land it properly....

Trott added a commit that referenced this pull request Sep 25, 2020
doc: put landing specifics in details tag
895832c 
Showing all the steps isn't usually useful and makes it seem like the
collaborator is meant to follow the manual steps. I've seen this happen
during at least one onboarding. The section is also a bit long to
comfortably scroll over quickly to find the next section.

Let's put those steps in a details block to make it more obvious that it
is there for unusual situations only.

Co-authored-by: Shelley Vohr <codebytere@gmail.com>

PR-URL: #35296
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

Trott commented Sep 25, 2020

Copy link
Copy Markdown
Member Author

Landed in 895832c

MylesBorins pushed a commit that referenced this pull request Sep 29, 2020
doc: put landing specifics in details tag
a8d3a7f 
Showing all the steps isn't usually useful and makes it seem like the
collaborator is meant to follow the manual steps. I've seen this happen
during at least one onboarding. The section is also a bit long to
comfortably scroll over quickly to find the next section.

Let's put those steps in a details block to make it more obvious that it
is there for unusual situations only.

Co-authored-by: Shelley Vohr <codebytere@gmail.com>

PR-URL: #35296
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
MylesBorins mentioned this pull request Sep 29, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
doc: put landing specifics in details tag
40ca80b 
Showing all the steps isn't usually useful and makes it seem like the
collaborator is meant to follow the manual steps. I've seen this happen
during at least one onboarding. The section is also a bit long to
comfortably scroll over quickly to find the next section.

Let's put those steps in a details block to make it more obvious that it
is there for unusual situations only.

Co-authored-by: Shelley Vohr <codebytere@gmail.com>

PR-URL: #35296
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
doc: put landing specifics in details tag
77555d8 
Showing all the steps isn't usually useful and makes it seem like the
collaborator is meant to follow the manual steps. I've seen this happen
during at least one onboarding. The section is also a bit long to
comfortably scroll over quickly to find the next section.

Let's put those steps in a details block to make it more obvious that it
is there for unusual situations only.

Co-authored-by: Shelley Vohr <codebytere@gmail.com>

PR-URL: #35296
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
doc: put landing specifics in details tag
701e9a7 
Showing all the steps isn't usually useful and makes it seem like the
collaborator is meant to follow the manual steps. I've seen this happen
during at least one onboarding. The section is also a bit long to
comfortably scroll over quickly to find the next section.

Let's put those steps in a details block to make it more obvious that it
is there for unusual situations only.

Co-authored-by: Shelley Vohr <codebytere@gmail.com>

PR-URL: nodejs#35296
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

codebytere codebytere left review comments
richardlau richardlau approved these changes
+2 more reviewers
targos targos approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL