tools: ignore build folder when checking links - #35315
Closed
AshCripps wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
richardlau
approved these changes
Sep 23, 2020
richardlau
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Optionally keep the names checked in alphabetical order.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Ah didn't spot they were in alphabetical order will change that |
Sorry, something went wrong.
We checkout build as a subdirectory as part of CI and if you run `make test` instead of `make test-ci` you get loads of errors about markdown link breaks. Ignore this directory as we don't need to examine another repo
AshCripps
force-pushed
the
ignore-build
branch
from
1c96dff to
2c55cc4
Compare
September 23, 2020 11:07
richardlau
approved these changes
Sep 23, 2020
Trott
approved these changes
Sep 23, 2020
Copy link
Copy Markdown
Member
|
Fast-track? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Sep 23, 2020
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35315 ✔ Done loading data for nodejs/node/pull/35315 ----------------------------------- PR info ------------------------------------ Title tools: ignore build folder when checking links (#35315) Author Ash Cripps (@AshCripps) Branch AshCripps:ignore-build -> nodejs:master Labels author ready, doc, fast-track, tools Commits 1 - tools: ignore build folder when checking links Committers 1 - Ash Cripps PR-URL: https://github.com/nodejs/node/pull/35315 Reviewed-By: Richard Lau Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35315 Reviewed-By: Richard Lau Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ✖ Last GitHub CI failed ℹ Last Full PR CI on 2020-09-23T11:36:52Z: https://ci.nodejs.org/job/node-test-pull-request/33210/ - Querying data for job/node-test-pull-request/33210/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Wed, 23 Sep 2020 10:54:46 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35315#pullrequestreview-494545968 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35315#pullrequestreview-494551596 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35315#pullrequestreview-494643274 ℹ This PR is being fast-tracked -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35315 ✔ Done loading data for nodejs/node/pull/35315 ----------------------------------- PR info ------------------------------------ Title tools: ignore build folder when checking links (#35315) Author Ash Cripps (@AshCripps) Branch AshCripps:ignore-build -> nodejs:master Labels author ready, doc, fast-track, tools Commits 1 - tools: ignore build folder when checking links Committers 1 - Ash Cripps PR-URL: https://github.com/nodejs/node/pull/35315 Reviewed-By: Richard Lau Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35315 Reviewed-By: Richard Lau Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ✖ GitHub CI is still running ℹ Last Full PR CI on 2020-09-24T09:23:04Z: https://ci.nodejs.org/job/node-test-pull-request/33210/ - Querying data for job/node-test-pull-request/33210/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Wed, 23 Sep 2020 10:54:46 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35315#pullrequestreview-494545968 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35315#pullrequestreview-494551596 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35315#pullrequestreview-494643274 ℹ This PR is being fast-tracked -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
Sorry, something went wrong.
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 24, 2020
We checkout build as a subdirectory as part of CI and if you run `make test` instead of `make test-ci` you get loads of errors about markdown link breaks. Ignore this directory as we don't need to examine another repo PR-URL: #35315 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 24, 2020
We checkout build as a subdirectory as part of CI and if you run `make test` instead of `make test-ci` you get loads of errors about markdown link breaks. Ignore this directory as we don't need to examine another repo PR-URL: #35315 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
We checkout build as a subdirectory as part of CI and if you run `make test` instead of `make test-ci` you get loads of errors about markdown link breaks. Ignore this directory as we don't need to examine another repo PR-URL: #35315 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
We checkout build as a subdirectory as part of CI and if you run `make test` instead of `make test-ci` you get loads of errors about markdown link breaks. Ignore this directory as we don't need to examine another repo PR-URL: #35315 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
We checkout build as a subdirectory as part of CI and if you run `make test` instead of `make test-ci` you get loads of errors about markdown link breaks. Ignore this directory as we don't need to examine another repo PR-URL: nodejs#35315 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We checkout build as a subdirectory as part of CI and
if you run make test instead of make test-ci you get
loads of errors about markdown link breaks. Ignore this
directory as we don't need to examine another repo
Checklist