doc: issue-3530 assert.markdown updated - #3533
Closed
birnam wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@birnam could you prefix the commit message with doc: and make sure it is no longer than 50 characters? |
Sorry, something went wrong.
birnam
force-pushed
the
issue-3530-assert-doc-correction
branch
from
6185451 to
06162e0
Compare
October 26, 2015 18:30
Copy link
Copy Markdown
Contributor
Author
|
commit is updated @Fishrock123 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Nov 3, 2015
PR-URL: #3533 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 7, 2015
PR-URL: #3533 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2015
PR-URL: #3533 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Copy link
Copy Markdown
Contributor
|
landed in lts-v4.x-staging as dfc2707 |
Sorry, something went wrong.
rvagg
pushed a commit
that referenced
this pull request
Dec 4, 2015
PR-URL: #3533 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Closed
jasnell
pushed a commit
that referenced
this pull request
Dec 17, 2015
PR-URL: #3533 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Dec 23, 2015
PR-URL: #3533 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for assert describes:
But assert.equal parameters are actual value first, then expected value. The documentation should read: