doc: unhide resolver spec - #35358
Closed
guybedford wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Ping @nodejs/modules-active-members for review here. |
Sorry, something went wrong.
MylesBorins
approved these changes
Sep 29, 2020
MylesBorins
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Trott
approved these changes
Sep 30, 2020
guybedford
added a commit
that referenced
this pull request
Oct 2, 2020
PR-URL: #35358 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
Landed in 9e0bc33. |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
PR-URL: #35358 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35358 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35358 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35358 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It comes up quite a bit that people ask me how to implement the Node.js resolver and they weren't necessarily aware there is a detailed specification available.
If we unhide the specification text I think this will make it clearer to more people that there is a very carefully well-defined resolution algorithm that tooling can follow.
We've moved content out of the esm.md page so that it seems like it adds less bloat too at this point.
I'm open to suggestions re moving this somewhere else, and don't feel too strongly that this should land either if anyone has any concerns about this approach as well.
//cc @nodejs/modules-active-members
Checklist