doc: update example url of ICU - #35373
Merged
Trott merged 1 commit intoSep 30, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
addaleax
approved these changes
Sep 29, 2020
richardlau
approved these changes
Sep 29, 2020
richardlau
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Typo (exmaple) in the commit message title but otherwise LGTM.
Sorry, something went wrong.
Trott
approved these changes
Sep 30, 2020
PR-URL: nodejs#35373 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
PR-URL: #35373 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35373 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host page of ICU package which is written as http://download.icu-project.org/files/icu4c/58.1/icu4c-58_1-src.tgz in the guide does not seem to available and they move to GitHub's release page for downloads. Refs http://site.icu-project.org/download/67#TOC-ICU4C-Download as an example. As a minor tweak, I also updated the version number of V8_MINIMUM_ICU_VERSION in the doc to sync with the actual code in deps/v8/src/objects/intl-objects.h.
Checklist