FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v12.x backport] CJS exports detection by guybedford · Pull Request #35405 · nodejs/node · GitHub

/ node Public

[v12.x backport] CJS exports detection - #35405

Closed
guybedford wants to merge 2 commits into
nodejs:v12.x-stagingfrom
guybedford:12-cjs-export-detection
ConversationCommits (2)ChecksFiles changed
Closed

[v12.x backport] CJS exports detection#35405
guybedford wants to merge 2 commits into
nodejs:v12.x-stagingfrom
guybedford:12-cjs-export-detection

Conversation

guybedford commented Sep 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This backports the CJS exports detection from #35249 and the error message adjustments from #35426 for 12.x.

This PR is based to the modules backports PR at #35385 so should land after that.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Sep 29, 2020 •
edited by codebytere
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/community-committee
  • @nodejs/modules
  • @nodejs/tsc

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v12.x labels Sep 29, 2020
guybedford force-pushed the 12-cjs-export-detection branch 3 times, most recently from 3627a5a to 0e3380a Compare October 1, 2020 03:56
GeoffreyBooth approved these changes Oct 1, 2020
View reviewed changes

GeoffreyBooth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approving that these PRs should be backported; haven’t specifically re-reviewed the code since the original PRs.

codebytere commented Oct 1, 2020

Copy link
Copy Markdown
Member

@guybedford can you rebase this?

mmarchini approved these changes Oct 1, 2020
View reviewed changes

mmarchini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

rslgtm

module: named exports for CJS via static analysis
aab2a8d 
PR-URL: nodejs#35249
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
module: refine module type mismatch error cases
0708932 
PR-URL: nodejs#35426
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
guybedford force-pushed the 12-cjs-export-detection branch from 0e3380a to 0708932 Compare October 1, 2020 23:34

guybedford commented Oct 1, 2020

Copy link
Copy Markdown
Contributor Author

@codebytere sure, thanks for looking into this, I've rebased the commits.

mcollina approved these changes Oct 2, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

nodejs-github-bot commented Oct 3, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33346/

nodejs-github-bot commented Oct 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33384/

codebytere mentioned this pull request Oct 4, 2020
Open

codebytere commented Oct 4, 2020

Copy link
Copy Markdown
Member

Landed in 2f3ffc0...5357a05

codebytere closed this Oct 4, 2020
codebytere pushed a commit that referenced this pull request Oct 4, 2020
module: named exports for CJS via static analysis
65ffce1 
PR-URL: #35249
Backport-PR-URL: #35405
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Oct 4, 2020
module: refine module type mismatch error cases
5357a05 
PR-URL: #35426
Backport-PR-URL: #35405
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

@codebytere we need to also include #35483 and preferably #35501 as well. When is the 12.x release planned for? We may want to bump some of the modules changes that only came out last week if we can have them bake a bit longer.

codebytere commented Oct 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

_@MylesBorins it's slated for tues 10/6 - what are your thoughts for which to bump? we could either

  1. remove the ones i just backported
  2. bump the release a week

MylesBorins commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

There are a bunch of modules backports that were part of this and the prior PR that have not been on Current for two weeks (they went out last week). Even if we bump a week some of the fixes haven't gone out yet. Are we still planning one more minor before maintenance?

guybedford mentioned this pull request Oct 22, 2020
Closed
7 tasks
aduh95 mentioned this pull request Oct 22, 2020
Closed
3 tasks
aduh95 reopened this Oct 22, 2020

aduh95 commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

Closing in favor of #35757

aduh95 closed this Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
GeoffreyBooth GeoffreyBooth approved these changes
codebytere codebytere approved these changes
+1 more reviewer
mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL