FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: add startup team in CODEOWNERS by joyeecheung · Pull Request #35406 · nodejs/node · GitHub

/ node Public

meta: add startup team in CODEOWNERS - #35406

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:startup-team
ConversationCommits (1)ChecksFiles changed
Closed

meta: add startup team in CODEOWNERS#35406
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:startup-team

Conversation

joyeecheung commented Sep 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #35215

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

joyeecheung added the meta Issues and PRs related to the general management of the project. label Sep 29, 2020

nodejs-github-bot commented Sep 29, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

joyeecheung mentioned this pull request Sep 29, 2020
Closed

gengjiawen commented Sep 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Looks like we will abandon build-in CODEOWNERS, see #35162 (comment). cc @mmarchini

joyeecheung commented Sep 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

@gengjiawen I thought the decision was to not rely on GitHub to do the ping but instead rely on the bot (which will parse the CODEOWNERS and ping people, like what it's doing in #35406 (comment))?

gengjiawen commented Sep 29, 2020

Copy link
Copy Markdown
Member

@gengjiawen I thought the decision was to not rely on GitHub to do the ping but instead rely on the bot (which will parse the CODEOWNERS and ping people, like what it's doing in #35406 (comment))?

Another thing is that you may want to is add this repo to startup team see: #35162 (comment).

gengjiawen approved these changes Sep 29, 2020
View reviewed changes

gengjiawen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like we set the team truly to startup :)

joyeecheung commented Sep 30, 2020

Copy link
Copy Markdown
Member Author

I am not sure whether we should add the team under nodejs/collaborators now (last time I checked there were permission issues?). Maybe @mmarchini has a clue?

mhdawson approved these changes Sep 30, 2020
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

XadillaX approved these changes Oct 1, 2020
View reviewed changes

XadillaX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

joyeecheung mentioned this pull request Oct 1, 2020
Closed
joyeecheung added a commit that referenced this pull request Oct 3, 2020
meta: add startup team in CODEOWNERS
f826760 
PR-URL: #35406
Fixes: #35215
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung commented Oct 3, 2020

Copy link
Copy Markdown
Member Author

Landed in f826760

joyeecheung closed this Oct 3, 2020
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
meta: add startup team in CODEOWNERS
2302206 
PR-URL: #35406
Fixes: #35215
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Oct 6, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
meta: add startup team in CODEOWNERS
3f66c09 
PR-URL: nodejs#35406
Fixes: nodejs#35215
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
codebytere codebytere approved these changes
gengjiawen gengjiawen approved these changes
richardlau richardlau approved these changes
gireeshpunathil gireeshpunathil approved these changes
+3 more reviewers
danbev danbev approved these changes
XadillaX XadillaX approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a nodejs/startup team
Back | FazBrowse Home | New Git URL