[v14.x backport] test: update wpt tests for encoding - #35422
Closed
watilde wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Refs: web-platform-tests/wpt#25542 PR-URL: nodejs#35330 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
3 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@MylesBorins Could you have a chance to review this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
MylesBorins
approved these changes
Oct 6, 2020
MylesBorins
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
BethGriggs
approved these changes
Oct 6, 2020
danielleadams
approved these changes
Oct 6, 2020
Copy link
Copy Markdown
Contributor
|
Landed in 552ebaf |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
Refs: web-platform-tests/wpt#25542 PR-URL: #35330 Backport-PR-URL: #35422 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: web-platform-tests/wpt#25542
PR-URL: #35330
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Shingo Inoue leko.noor@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Checklist