tools,doc: fix broken link in module.html - #35446
Closed
Trott wants to merge 0 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
Oct 1, 2020
Copy link
Copy Markdown
Member
|
There shouldn't be any reason this has to wait to land. fast-track? |
Sorry, something went wrong.
richardlau
approved these changes
Oct 1, 2020
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35446 ✔ Done loading data for nodejs/node/pull/35446 ----------------------------------- PR info ------------------------------------ Title tools,doc: fix broken link in module.html (#35446) Author Rich Trott (@Trott) Branch Trott:fix-broken-sourcemap-link -> nodejs:master Labels doc, fast-track, tools Commits 1 - tools,doc: fix broken link in module.html Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/35446 Reviewed-By: James M Snell Reviewed-By: Richard Lau ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35446 Reviewed-By: James M Snell Reviewed-By: Richard Lau -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected ℹ This PR was created on Thu, 01 Oct 2020 13:59:27 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/35446#pullrequestreview-500443557 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35446#pullrequestreview-500539970 ℹ This PR is being fast-tracked -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gireeshpunathil
approved these changes
Oct 2, 2020
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 3, 2020
Update tools/doc/type-parser.js with correct URL for the module.SourceMap class. This fixes a broken link in our documentation. PR-URL: nodejs#35446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Trott
force-pushed
the
fix-broken-sourcemap-link
branch
from
6acf554 to
e9639ee
Compare
October 3, 2020 12:43
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
Update tools/doc/type-parser.js with correct URL for the module.SourceMap class. This fixes a broken link in our documentation. PR-URL: #35446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Update tools/doc/type-parser.js with correct URL for the module.SourceMap class. This fixes a broken link in our documentation. PR-URL: nodejs#35446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tools/doc/type-parser.js with correct URL for the
module.SourceMap class. This fixes a broken link in our documentation.
Checklist