FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix deprecation history by aduh95 · Pull Request #35455 · nodejs/node · GitHub

/ node Public

doc: fix deprecation history - #35455

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:fix-deprecation-history
ConversationCommits (1)ChecksFiles changed
Closed

doc: fix deprecation history#35455
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:fix-deprecation-history

Conversation

aduh95 commented Oct 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • DEP0089(9692df7) was backported to v8.13.0. It's not in the v10.x changelog as it was already in v9.x.
  • DEP0098(efb3259) doesn't appear anywhere in the v9.x nor v8.x changelogs, I don't think it's ever been backported.
  • DEP0140: was introduced by http: doc deprecate abort and improve docs #32807 and landed in v14.1.0 and v13.14.0
  • DEP0144: just landed on v12.19.0
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Oct 1, 2020

Trott commented Oct 2, 2020

Copy link
Copy Markdown
Member

DEP0098 was added to v8.x in daacff8. Backport PR is #19517.

aduh95 commented Oct 2, 2020
View reviewed changes
Comment thread doc/api/deprecations.md Outdated

Trott commented Oct 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

The DEP0098 thing is a bit more complicated, but it was added to 9.x in a4c28d77f73 after having been (accidentally, I think) removed in bae5de1, prior to which it was added in 7f5334e. Backport PR for it being added to 9.x is #18892.

By the way, I'm finding these by doing git checkout upstream/v9.x, checking to see if the deprecation is in deprecations.md, and then doing git blame to see when it was added.

aduh95 commented Oct 4, 2020
View reviewed changes
Comment thread doc/api/deprecations.md Outdated

aduh95 commented Oct 4, 2020

Copy link
Copy Markdown
Contributor Author

By the way, I'm finding these by doing git checkout upstream/v9.x, checking to see if the deprecation is in deprecations.md, and then doing git blame to see when it was added.

Oh that's a neat idea. I was simply searching through the CHANGELOG files, which is clearly not as reliable.

I've removed the changes related to DEP0098, PTAL.

aduh95 force-pushed the fix-deprecation-history branch from d66f299 to 88a8087 Compare October 6, 2020 22:56

aduh95 commented Oct 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I've included two more fixes, PTAL:

Trott approved these changes Oct 7, 2020
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber-stamp LGTM

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2020
github-actions Bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 7, 2020

github-actions Bot commented Oct 7, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/35455
✔  Done loading data for nodejs/node/pull/35455
----------------------------------- PR info ------------------------------------
Title      doc: fix deprecation history (#35455)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:fix-deprecation-history -> nodejs:master
Labels     commit-queue, deprecations, doc
Commits    1
 - doc: fix deprecation history
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/35455
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35455
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Doc-only changes
   ℹ  This PR was created on Thu, 01 Oct 2020 22:46:31 GMT
   ✔  Approvals: 1
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35455#pullrequestreview-503530131
   ✖  This PR needs to wait 30 more hours to land (or 0 hours if there is one more approval)
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 8, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2020

github-actions Bot commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Landed in ef1af47

github-actions Bot closed this Oct 8, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 8, 2020
doc: fix deprecation history
ef1af47 
PR-URL: #35455
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
doc: fix deprecation history
51b988b 
PR-URL: #35455
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
doc: fix deprecation history
72238da 
PR-URL: nodejs#35455
Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95 deleted the fix-deprecation-history branch July 16, 2022 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes

Assignees

No one assigned

Labels

deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL