FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: improve eventLoopUtilization documentation by puzpuzpuz · Pull Request #35479 · nodejs/node · GitHub

/ node Public

doc: improve eventLoopUtilization documentation - #35479

Closed
puzpuzpuz wants to merge 1 commit into
nodejs:masterfrom
puzpuzpuz:cleanup/improve-perf-hooks-doc
Closed

doc: improve eventLoopUtilization documentation#35479
puzpuzpuz wants to merge 1 commit into
nodejs:masterfrom
puzpuzpuz:cleanup/improve-perf-hooks-doc

Conversation

puzpuzpuz commented Oct 3, 2020
edited
Loading

Copy link
Copy Markdown
Member

I've noticed a few things that could be improved in the doc, like incorrect util1 argument name.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Oct 3, 2020
addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2020

github-actions Bot commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

Landed in 642f206

github-actions Bot closed this Oct 5, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 5, 2020
PR-URL: #35479
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
danielleadams mentioned this pull request Oct 6, 2020
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
PR-URL: #35479
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
puzpuzpuz deleted the cleanup/improve-perf-hooks-doc branch October 11, 2020 12:25
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35479
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL