test: split independent tests into separate files - #3548
Closed
Trott wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM. Let's see how the CI feels. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
You can constify the file. Apart from that, LGTM. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Constified, thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
rvagg
pushed a commit
to rvagg/io.js
that referenced
this pull request
Oct 29, 2015
Move ENOENT related tests out of general fs.watch() test file and into its own file. This may help diagnose nodejs#3541. PR-URL: nodejs#3548 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This was referenced Oct 29, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ENOENT related tests out of general fs.watch() test file and into its own file. This may help diagnose #3541.
/cc @jbergstroem @cjihrig @charlierudolph