FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: more global primordials by targos · Pull Request #35499 · nodejs/node · GitHub

/ node Public

lib: more global primordials - #35499

Closed
targos wants to merge 7 commits into
nodejs:masterfrom
targos:more-primordials
ConversationCommits (7)ChecksFiles changed
Closed

lib: more global primordials#35499
targos wants to merge 7 commits into
nodejs:masterfrom
targos:more-primordials

Conversation

targos commented Oct 4, 2020

Copy link
Copy Markdown
Member

commit 1b7578c (HEAD -> more-primordials, origin/more-primordials)

lib: use remaining typed arrays from primordials

commit fef731c

lib: use Number.parseFloat from primordials

commit 99bed01

lib: use Number.parseInt from primordials

commit 5d6751b

lib: use global Error constructors from primordials

commit de9118b

errors: support possible deletion of globalThis.Error

Do not crash trying to access prepareStackTrace on `undefined`.

targos requested review from a team as code owners October 4, 2020 14:11
targos requested a review from a team October 4, 2020 14:11

nodejs-github-bot commented Oct 4, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/modules
  • @nodejs/net
  • @nodejs/quic
  • @nodejs/startup
  • @nodejs/streams

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 4, 2020
targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020

nodejs-github-bot commented Oct 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33380/

targos mentioned this pull request Oct 4, 2020
Closed
3 tasks
ljharb reviewed Oct 4, 2020
View reviewed changes
Comment thread lib/internal/dns/utils.js Outdated
Comment thread lib/internal/dns/utils.js Outdated
Comment thread lib/repl.js Outdated
Comment thread lib/repl.js Outdated
ryzokuken reviewed Oct 6, 2020
View reviewed changes

ryzokuken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with @ljharb's suggestions applied.

ryzokuken approved these changes Oct 6, 2020
View reviewed changes

ryzokuken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, missed the approve button.

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2020

nodejs-github-bot commented Oct 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33429/

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2020

github-actions Bot commented Oct 7, 2020

Copy link
Copy Markdown
Contributor

Landed in 1469984

github-actions Bot closed this Oct 7, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 7, 2020
errors: support possible deletion of globalThis.Error
46526d6 
Do not crash trying to access prepareStackTrace on `undefined`.

PR-URL: #35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Oct 7, 2020
lib: use global Error constructors from primordials
4bc4f88 
PR-URL: #35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Oct 7, 2020
lib: use Number.parseInt from primordials
a073f53 
PR-URL: #35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Oct 7, 2020
lib: use Number.parseFloat from primordials
0708736 
PR-URL: #35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Oct 7, 2020
lib: use remaining typed arrays from primordials
1469984 
PR-URL: #35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
targos deleted the more-primordials branch October 7, 2020 14:07
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
errors: support possible deletion of globalThis.Error
3c90b1a 
Do not crash trying to access prepareStackTrace on `undefined`.

PR-URL: #35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
lib: use global Error constructors from primordials
77f1e1e 
PR-URL: #35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
lib: use Number.parseInt from primordials
5d727f0 
PR-URL: #35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
lib: use Number.parseFloat from primordials
7e8fdd3 
PR-URL: #35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
lib: use remaining typed arrays from primordials
fa171db 
PR-URL: #35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
MylesBorins mentioned this pull request Oct 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
lib: use remaining typed arrays from primordials
f727998 
PR-URL: #35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
lib: use remaining typed arrays from primordials
ad7281b 
PR-URL: #35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
errors: support possible deletion of globalThis.Error
5b74c64 
Do not crash trying to access prepareStackTrace on `undefined`.

PR-URL: nodejs#35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
lib: use global Error constructors from primordials
bf3ae8f 
PR-URL: nodejs#35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
lib: use Number.parseInt from primordials
0faadb5 
PR-URL: nodejs#35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
lib: use Number.parseFloat from primordials
9df61b3 
PR-URL: nodejs#35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
lib: use remaining typed arrays from primordials
eea53c8 
PR-URL: nodejs#35499
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb left review comments
Trott Trott approved these changes
addaleax addaleax approved these changes
benjamingr benjamingr approved these changes
joyeecheung joyeecheung approved these changes
+2 more reviewers
Leko Leko approved these changes
ryzokuken ryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL