FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: edit fs.md for minor style changes by Trott · Pull Request #35505 · nodejs/node · GitHub

/ node Public

doc: edit fs.md for minor style changes - #35505

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:fs-might
Oct 12, 2020
Merged

doc: edit fs.md for minor style changes#35505
Trott merged 1 commit into
nodejs:masterfrom
Trott:fs-might

Conversation

Trott commented Oct 5, 2020

Copy link
Copy Markdown
Member

Prefer present tense and use "might" for possibility.

Checklist

nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Oct 5, 2020

Trott commented Oct 7, 2020

Copy link
Copy Markdown
Member Author

@nodejs/documentation

aymen94 commented Oct 7, 2020

Copy link
Copy Markdown
Member

👍 LGTM

Trott commented Oct 8, 2020

Copy link
Copy Markdown
Member Author

@nodejs/fs

Trott force-pushed the fs-might branch 3 times, most recently from e0bdf2c to ab2503d Compare October 12, 2020 14:11
Prefer present tense and use "might" for possibility.

PR-URL: nodejs#35505
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

Trott commented Oct 12, 2020

Copy link
Copy Markdown
Member Author

Landed in a844387

Trott merged commit a844387 into nodejs:master Oct 12, 2020
Trott deleted the fs-might branch October 12, 2020 14:17
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
Prefer present tense and use "might" for possibility.

PR-URL: #35505
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MylesBorins mentioned this pull request Oct 14, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Prefer present tense and use "might" for possibility.

PR-URL: nodejs#35505
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL