doc: fix YAML syntax errors - #35529
Closed
aduh95 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jasnell
approved these changes
Oct 6, 2020
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Please 👍🏻 to fast-track
Sorry, something went wrong.
cjihrig
approved these changes
Oct 6, 2020
Copy link
Copy Markdown
Member
|
looks like there may be another one in there...
|
Sorry, something went wrong.
aduh95
force-pushed
the
fix-build_docs-ci
branch
from
388d528 to
d1044ff
Compare
October 6, 2020 21:31
aduh95
force-pushed
the
fix-build_docs-ci
branch
from
d1044ff to
ff5e903
Compare
October 6, 2020 21:34
Copy link
Copy Markdown
Contributor
Author
|
OK, build-docs now passes, PTAL. |
Sorry, something went wrong.
jasnell
approved these changes
Oct 6, 2020
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35529 ✔ Done loading data for nodejs/node/pull/35529 ----------------------------------- PR info ------------------------------------ Title doc: fix YAML syntax errors (#35529) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:fix-build_docs-ci -> nodejs:master Labels doc, fast-track, zlib Commits 1 - doc: fix YAML syntax errors Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/35529 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35529 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ✖ GitHub CI is still running ℹ Doc-only changes ℹ This PR was created on Tue, 06 Oct 2020 21:26:48 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/35529#pullrequestreview-503377599 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/35529#pullrequestreview-503372496 ℹ This PR is being fast-tracked -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Will land as soon as the CI finishes up |
Sorry, something went wrong.
2 tasks
richardlau
approved these changes
Oct 6, 2020
Copy link
Copy Markdown
Contributor
Author
|
CI is red on test-linux-with-quic: test-net-listen-ipv6only and green otherwise. |
Sorry, something went wrong.
BethGriggs
approved these changes
Oct 6, 2020
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2020
PR-URL: #35529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 13, 2020
PR-URL: #35529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This was referenced Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems v12.19.0 release commit contains an unintended YAML syntax error, which causes CI to fail for every PR.
cc @codebytere
Checklist